Skip to content

Remove @aat tests that our duplicated by axe.test.ts - #5648

Merged
kendallgassner merged 3 commits into
mainfrom
kendallg/clean-up-aat-test-dups
Feb 3, 2025
Merged

Remove @aat tests that our duplicated by axe.test.ts#5648
kendallgassner merged 3 commits into
mainfrom
kendallg/clean-up-aat-test-dups

Conversation

@kendallgassner

@kendallgassnerkendallgassner commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

In #5592 we created a script that would run axe on every singles Storybook story (unless added to SKIPPED_TESTS. Doing so allows us to remove several @aat tests in our e2e testing suite that are duplicated by the axe tests. This PR removes some of those tests. A follow up PR will remove more.

This PR does/should not remove any @aat tests that runs axe when a state is changed. For example if an @aat test opens a dialog in the storybook story the axe.test.ts script would not be a duplicate of that test.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Feb 3, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4ddd00b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kendallgassnerkendallgassner added the skip changeset This change does not need a changelog label Feb 3, 2025
@github-actions

github-actionsBot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.38 KB (0%)
packages/react/dist/browser.umd.js105.83 KB (0%)

@kendallgassnerkendallgassner changed the title Remove @aat tests that our duplicated by axe.test.ts[Draft] Remove @aat tests that our duplicated by axe.test.tsFeb 3, 2025
@github-actions
github-actionsBot requested a deployment to storybook-preview-5648 February 3, 2025 18:40 Abandoned
@kendallgassner

Copy link
Copy Markdown
ContributorAuthor

I don't think this @vrt failure is related to this change.

@kendallgassner
kendallgassner marked this pull request as ready for review February 3, 2025 19:12
@kendallgassner
kendallgassner requested a review from a team as a code ownerFebruary 3, 2025 19:12

@khiga8khiga8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kendallgassner
kendallgassner added this pull request to the merge queueFeb 3, 2025
Merged via the queue into main with commit 4eab002Feb 3, 2025
@kendallgassner
kendallgassner deleted the kendallg/clean-up-aat-test-dups branch February 3, 2025 22:18
@kendallgassnerkendallgassner changed the title [Draft] Remove @aat tests that our duplicated by axe.test.tsRemove @aat tests that our duplicated by axe.test.tsFeb 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kendallgassner@joshblack@khiga8