Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-pillows-change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

SubNav: Adds `aria-current` to selected links
1 change: 1 addition & 0 deletions packages/react/src/SubNav/SubNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ const SubNavLink = React.forwardRef<HTMLElement, StyledSubNavLinkProps>(function
ref={forwardRef}
className={clsx(className, enabled && styles.Link)}
data-selected={rest.selected}
aria-current={rest.selected}
{...rest}
>
{children}
Expand Down
16 changes: 16 additions & 0 deletions packages/react/src/__tests__/SubNav.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,20 @@ describe('SubNav', () => {
expect(getByTestId('action')).toBeInTheDocument()
expect(getByTestId('action').parentElement).toHaveClass('SubNav-actions')
})

it('sets aria-current on the selected child', () => {
const {getByTestId} = HTMLRender(
<SubNav>
<SubNav.Link to="/foo" data-testid="foo" selected>
Foo
</SubNav.Link>
<SubNav.Link to="/bar" data-testid="bar">
Bar
</SubNav.Link>
</SubNav>,
)

expect(getByTestId('foo')).toHaveAttribute('aria-current', 'true')
expect(getByTestId('bar')).not.toHaveAttribute('aria-current')
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ exports[`SubNav.Link respects the "selected" prop 1`] = `
}

<a
aria-current={true}
className="c0 SubNav-item selected"
data-selected={true}
selected={true}
Expand Down