Skip to content

Radio: Remove the sx prop - #5697

Closed
TylerJDev wants to merge 4 commits into
mainfrom
tylerjdev/remove-sx-from-radio
Closed

Radio: Remove the sx prop#5697
TylerJDev wants to merge 4 commits into
mainfrom
tylerjdev/remove-sx-from-radio

Conversation

@TylerJDev

@TylerJDevTylerJDev commented Feb 14, 2025

Copy link
Copy Markdown
Member

Removes the sx prop from Radio

Also removes a lint disable!

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Feb 14, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6966a82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 14, 2025
@github-actions

github-actionsBot commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js106.02 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js106.29 KB (-0.05% 🔽)

@github-actions
github-actionsBot requested a deployment to storybook-preview-5697 February 14, 2025 19:48 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5697 February 14, 2025 20:04 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 14, 2025
@lesliecdubs

Copy link
Copy Markdown
Member

Hey @TylerJDev, is this one ready for a review or does it need a little more work?

@TylerJDev

Copy link
Copy Markdown
MemberAuthor

Hey @lesliecdubs! The only thing that was blocking this PR were instances of sx in Dotcom. I had a branch working on this but haven't pushed anything up yet. I'll double check to make sure that they still exist, and if so will work on a PR in Dotcom which should unblock this PR!

@primer-integration

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/366392

@primer-integration

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Mar 11, 2025
@TylerJDev

Copy link
Copy Markdown
MemberAuthor

Moving this work to #5760, as I see there's a plan to remove the sx props in the next major release. We can still remove the lint disables in the meantime.

@primer
primerBot deleted the tylerjdev/remove-sx-from-radio branch June 30, 2026 18:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TylerJDev@lesliecdubs