Uh oh!
There was an error while loading. Please reload this page.
Fix banner alignment with actions - #6326
Conversation
🦋 Changeset detectedLatest commit: f917078 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
10b4b8d to
464218fCompareThere was a problem hiding this comment.
Pull Request Overview
This PR fixes a visual alignment issue in the Banner component where icons and descriptions become misaligned when the component has both hidden titles and actions. The fix ensures that styling adjustments for hidden titles are only applied when actions are not present.
- Updates CSS selectors to conditionally apply hidden-title styles only when actions are absent
- Adds a changeset file to document the patch release
Reviewed Changes
Copilot reviewed 2 out of 35 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/Banner/Banner.module.css | Updates CSS selectors to fix alignment by excluding banners with actions from hidden-title styling |
| .changeset/tame-dancers-count.md | Adds changeset documentation for the patch release |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: adierkens <13004162+adierkens@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@github.com>
Updates the styling of the banner component that includes a hidden-title and actions. Today, the presence of actions causes the icon and description to become misaligned (non-vertically centered), because the margins are updated to be slightly smaller when titles are hidden.
Rollout strategy
Testing & Reviewing
Review storybook & VRTs
Merge checklist