Skip to content

Fix banner alignment with actions#6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 4 commits into from
Jul 16, 2025
Merged

Fix banner alignment with actions #6326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
464218f
Fix banner alignment with actions
adierkens Jul 16, 2025
341915f
test(vrt): update snapshots
adierkens Jul 16, 2025
7eea14c
only update the banner snapshots
adierkens Jul 16, 2025
f917078
Merge branch 'main' into adierkens/banner-alignment
joshblack Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-dancers-count.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Fix alignment styles for Banner component with hidden titles
Binary file modified...snapshots/Banner-DismissibleWithHiddenTitleAndActions-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified....ts-snapshots/Banner-DismissibleWithHiddenTitleAndActions-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...pshots/Banner-DismissibleWithHiddenTitleAndActions-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...er.test.ts-snapshots/Banner-DismissibleWithHiddenTitleAndActions-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...snapshots/Banner-DismissibleWithHiddenTitleAndActions-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...napshots/Banner-DismissibleWithHiddenTitleAndActions-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...shots/Banner-DismissibleWithHiddenTitleAndActions-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...r.test.ts-snapshots/Banner-DismissibleWithHiddenTitleAndActions-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...napshots/Banner-DismissibleWithHiddenTitleAndActions-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...hots/Banner-DismissibleWithHiddenTitleAndActions-primer-breakpoint-sm-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...hots/Banner-DismissibleWithHiddenTitleAndActions-primer-breakpoint-xs-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...s/Banner-DismissibleWithHiddenTitleAndSecondaryAction-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...shots/Banner-DismissibleWithHiddenTitleAndSecondaryAction-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...anner-DismissibleWithHiddenTitleAndSecondaryAction-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...ts-snapshots/Banner-DismissibleWithHiddenTitleAndSecondaryAction-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...s/Banner-DismissibleWithHiddenTitleAndSecondaryAction-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified.../Banner-DismissibleWithHiddenTitleAndSecondaryAction-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...nner-DismissibleWithHiddenTitleAndSecondaryAction-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...s-snapshots/Banner-DismissibleWithHiddenTitleAndSecondaryAction-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified.../Banner-DismissibleWithHiddenTitleAndSecondaryAction-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...ner-DismissibleWithHiddenTitleAndSecondaryAction-primer-breakpoint-sm-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...ner-DismissibleWithHiddenTitleAndSecondaryAction-primer-breakpoint-xs-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...er.test.ts-snapshots/Banner-WithHiddenTitleAndActions-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...Banner.test.ts-snapshots/Banner-WithHiddenTitleAndActions-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...test.ts-snapshots/Banner-WithHiddenTitleAndActions-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...onents/Banner.test.ts-snapshots/Banner-WithHiddenTitleAndActions-dark-linux.png
View file
Open in desktop
Binary file modified...er.test.ts-snapshots/Banner-WithHiddenTitleAndActions-dark-tritanopia-linux.png
View file
Open in desktop
Binary file modified...r.test.ts-snapshots/Banner-WithHiddenTitleAndActions-light-colorblind-linux.png
View file
Open in desktop
Binary file modified...est.ts-snapshots/Banner-WithHiddenTitleAndActions-light-high-contrast-linux.png
View file
Open in desktop
Binary file modified...nents/Banner.test.ts-snapshots/Banner-WithHiddenTitleAndActions-light-linux.png
View file
Open in desktop
Binary file modified...r.test.ts-snapshots/Banner-WithHiddenTitleAndActions-light-tritanopia-linux.png
View file
Open in desktop
Binary file modified...st.ts-snapshots/Banner-WithHiddenTitleAndActions-primer-breakpoint-sm-linux.png
View file
Open in desktop
Binary file modified...st.ts-snapshots/Banner-WithHiddenTitleAndActions-primer-breakpoint-xs-linux.png
View file
Open in desktop
5 changes: 3 additions & 2 deletions packages/react/src/Banner/Banner.module.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@
margin-block: var(--base-size-8);
}

.Banner[data-title-hidden] .BannerContent {
.Banner[data-title-hidden]:not(:has(.BannerActions)) .BannerContent {
margin-block: var(--base-size-6);
}

Expand DownExpand Up@@ -108,7 +108,8 @@
fill: var(--banner-icon-fgColor);
}

.Banner[data-title-hidden] .BannerIcon svg {
/* stylelint-disable-next-line selector-max-specificity */
.Banner[data-title-hidden]:not(:has(.BannerActions)) .BannerIcon svg {
height: var(--base-size-16);
}

Expand Down