Skip to content

Breadcrumbs : Add overflow menu for responsive behavior - #6664

Merged
pksjce merged 63 commits into
mainfrom
pk/breadcrumbs-with-overflow-menu
Sep 11, 2025
Merged

Breadcrumbs : Add overflow menu for responsive behavior#6664
pksjce merged 63 commits into
mainfrom
pk/breadcrumbs-with-overflow-menu

Conversation

@pksjce

@pksjcepksjce commented Aug 25, 2025•
edited by jonrohan
Loading

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/github/primer/issues/5122

Changelog

Breadcrumbs now show an overflow menu with the following features

  • If no of items in the breadcrumbs is >5 then we show the menu
  • If the screen width can't accomodate the items then we show the menu
  • if overflow==="menu-with-root" show the root item.

https://www.loom.com/share/8902798416b741c9959fc7bb501185a5

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings August 25, 2025 11:48
@pksjce
pksjce requested a review from a team as a code ownerAugust 25, 2025 11:48
@changeset-bot

changeset-botBot commented Aug 25, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 71753ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactPatch
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 25, 2025
@github-actions

github-actionsBot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

This comment was marked as spam.

Sign in to view

@github-actions

github-actionsBot commented Aug 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js89.54 KB (+1.02% 🔺)
packages/react/dist/browser.umd.js89.66 KB (+1.05% 🔺)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6664 September 8, 2025 07:00 Inactive
@pksjce

pksjce commented Sep 8, 2025

Copy link
Copy Markdown
ContributorAuthor

@joshblack - I have created this issue for the Esc button bug. It emerged because I made the IconButton of as summary.
Thanks for catching it. Will fix it separately

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6664 September 8, 2025 07:42 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6664 September 9, 2025 00:35 Inactive
strackoverflow
strackoverflow approved these changes Sep 9, 2025
View reviewed changes

@strackoverflowstrackoverflow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6664 September 9, 2025 21:42 Inactive
@pksjcepksjce added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Sep 10, 2025
@pksjce
pksjce enabled auto-merge September 10, 2025 05:03
@francinelucca
francinelucca removed their request for review September 10, 2025 14:29
@pksjce
pksjce disabled auto-merge September 11, 2025 22:03
@pksjce
pksjce added this pull request to the merge queueSep 11, 2025
Merged via the queue into main with commit 2910207Sep 11, 2025
46 checks passed
@pksjce
pksjce deleted the pk/breadcrumbs-with-overflow-menu branch September 11, 2025 22:10
@primerprimerBot mentioned this pull request Sep 11, 2025
Merged
pksjce added a commit that referenced this pull request Sep 18, 2025
@pksjce@dependabot
@joshblack@langermank
Breadcrumbs : Add overflow menu for responsive behavior (#6664)
73af8f1
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
This was referenced Aug 19, 2026
Merged
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkpsiddharthkpsiddharthkp left review comments
@adierkensadierkensadierkens left review comments
@francineluccafrancineluccafrancinelucca left review comments
Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@strackoverflowstrackoverflowstrackoverflow approved these changes
@hussam-i-amhussam-i-amhussam-i-am approved these changes
@langermanklangermankAwaiting requested review from langermanklangermank was automatically assigned from primer/design-reviewers
@joshblackjoshblackAwaiting requested review from joshblack
@janmaarten-a11yjanmaarten-a11yAwaiting requested review from janmaarten-a11y

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghintegration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@pksjce@strackoverflow@hussam-i-am@siddharthkp@joshblack@adierkens@langermank@francinelucca@janmaarten-a11y