Uh oh!
There was an error while loading. Please reload this page.
Revert the Timeline event taxonomy source module - #8321
Conversation
This reverts commit 3d384fa.
|
|
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Reverts the previously introduced Timeline event taxonomy source module so Primer remains taxonomy-agnostic, keeping taxonomy ownership in github-ui.
Changes:
- Deletes the Timeline taxonomy module files under
packages/react/src/Timeline/taxonomy/(types, catalogs, projections, and tests). - Removes the ESLint
camelcaseoverride that was scoped specifically to the deleted taxonomy file.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/Timeline/taxonomy/surfaces.ts | Removed the Timeline surface union and security-alert surface helpers. |
| packages/react/src/Timeline/taxonomy/index.ts | Removed taxonomy module public entry point re-exports. |
| packages/react/src/Timeline/taxonomy/eventTaxonomy.ts | Removed the combined taxonomy catalogs and projection utilities. |
| packages/react/src/Timeline/taxonomy/eventTaxonomy.test.ts | Removed tests validating the taxonomy catalogs and projections. |
| packages/react/src/Timeline/taxonomy/eventCategories.ts | Removed event category model and surface/category mapping helpers. |
| packages/react/src/Timeline/taxonomy/actorType.ts | Removed actor type classification and login-based resolution helper. |
| eslint.config.mjs | Removed the camelcase override targeting the deleted taxonomy file. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
This reverts #8180. The team wants the Timeline event taxonomy to live in github-ui rather than in Primer, so Primer stays taxonomy-agnostic and ships only the Timeline component and, later, an optional presentational Timeline.Filter control. Nothing on main imports the taxonomy module, so removing it is safe. The related Primer taxonomy PR #8216 closes unmerged, and its branch stays preserved so github-ui can lift the model from it. This PR stays a draft pending the closing comments on #8216, #6664, and #6654.
Changelog
New
None.
Changed
None.
Removed
Remove the Timeline event taxonomy source module under packages/react/src/Timeline/taxonomy, which covers actorType.ts, eventCategories.ts, eventTaxonomy.ts, eventTaxonomy.test.ts, surfaces.ts, and index.ts. Remove the matching camelcase override block for that module from eslint.config.mjs.
Rollout strategy
The taxonomy module never appears in the public @primer/react entry point and nothing on main imports it, so this revert makes no consumer-facing change and needs no changeset.
Testing & Reviewing
Run git revert on the #8180 squash commit, which applies cleanly with no conflicts and touches exactly seven files: it deletes the six files under packages/react/src/Timeline/taxonomy and removes the eight-line camelcase override from eslint.config.mjs. A repo-wide search finds no remaining references to the taxonomy module, and the Timeline component and its surface stories stay untouched. Type checking with tsc, linting with eslint at zero warnings across eslint.config.mjs and the Timeline directory, prettier formatting, and the @primer/react build all pass.