Skip to content

Revert TextInputWithWrapper changes to remove sx and styled-system - #6846

Merged
mperrotti merged 5 commits into
mainfrom
mp/temp-TextInput-sx-revived
Sep 15, 2025
Merged

Revert TextInputWithWrapper changes to remove sx and styled-system#6846
mperrotti merged 5 commits into
mainfrom
mp/temp-TextInput-sx-revived

Conversation

@mperrotti

@mperrottimperrotti commented Sep 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts component changes from #6666

Slack thread for context.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti
mperrotti requested a review from a team as a code ownerSeptember 12, 2025 17:28
@mperrotti
mperrotti requested review from Copilot and hectahertz and removed request for CopilotSeptember 12, 2025 17:28
@changeset-bot

changeset-botBot commented Sep 12, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 281f1ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactPatch
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 12, 2025
joshblack
joshblack reviewed Sep 12, 2025
View reviewed changes
Comment thread.changeset/silly-parks-give.md

@joshblackjoshblackSep 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a changeset here since the change hasn't been released yet if that's helpful!

@mperrottimperrottiSep 15, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need it to kick off the Canary release that's necessary for integration tests?

@joshblackjoshblackSep 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! You should be good. I think the workflow will force a "fake" changeset so that it always publishes something if I remember right

@github-actions

github-actionsBot commented Sep 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js89.75 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js89.89 KB (-0.01% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6846 September 12, 2025 17:37 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 12, 2025
CopilotAI review requested due to automatic review settings September 12, 2025 18:03
CopilotAI reviewed Sep 12, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the sx prop to TextInput and related components that was removed in a previous change. The sx prop allows for custom styling using the design system's styling API.

  • Adds sx prop support back to TextInput, Textarea, and their underlying wrapper components
  • Updates type definitions to include SxProp in component interfaces
  • Adds new Storybook stories to demonstrate sx prop usage

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
packages/react/src/internal/components/TextInputWrapper.tsxAdds SxProp to TextInputBaseWrapper type and imports
packages/react/src/Textarea/Textarea.tsxAdds sx prop support to Textarea component
packages/react/src/TextInput/TextInput.tsxAdds sx prop support to TextInput component
packages/react/src/TextInput/TextInput.dev.stories.tsxAdds Storybook stories demonstrating sx prop usage
.changeset/silly-parks-give.mdDocuments the change for release notes

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6846 September 12, 2025 18:12 Inactive
@mperrottimperrotti changed the title Add sx prop back to TextInputRevert TextInputWithWrapper changes to remove sx and styled-systemSep 15, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6846 September 15, 2025 20:53 Inactive
@mperrottimperrotti mentioned this pull request Sep 15, 2025
Merged
13 tasks
@primer-integration

primer-integrationBot commented Sep 15, 2025

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2528

@primer-integration

primer-integrationBot commented Sep 15, 2025

Copy link
Copy Markdown

🟢 ci completed with status success.

@github-actionsgithub-actionsBot removed the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Sep 15, 2025
@github-actionsgithub-actionsBot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Sep 15, 2025
@mperrotti
mperrotti added this pull request to the merge queueSep 15, 2025
@mperrottimperrotti mentioned this pull request Sep 15, 2025
Closed
13 tasks
Merged via the queue into main with commit 37ce4aaSep 15, 2025
46 checks passed
@mperrotti
mperrotti deleted the mp/temp-TextInput-sx-revived branch September 15, 2025 21:37
@primerprimerBot mentioned this pull request Sep 15, 2025
Merged
pksjce pushed a commit that referenced this pull request Sep 18, 2025
@mperrotti@pksjce
RevertTextInputWithWrapperchanges to remove sx and styled-system (#…
554e4d2
…6846)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@hectahertzhectahertzhectahertz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mperrotti@joshblack@hectahertz