Uh oh!
There was an error while loading. Please reload this page.
Remove styled-system usage - TextInputWrapper and related - #6666
Conversation
🦋 Changeset detectedLatest commit: eb29047 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Pull Request Overview
This pull request removes styled-system usage from TextInputWrapper and related input components as part of the migration away from styled-system dependencies. The changes eliminate the sx prop and width-related props from multiple input components and their wrapper.
- Removes styled-system imports and
SxPropusage from input components - Eliminates deprecated width, minWidth, and maxWidth props from TextInputWrapper
- Updates component type definitions to remove styled-system prop references
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/internal/components/TextInputWrapper.tsx | Removes styled-system imports, width props, and sx prop from TextInputBaseWrapper |
| packages/react/src/Textarea/Textarea.tsx | Removes SxProp import and sx prop usage |
| packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx | Removes sx and width-related props from component |
| packages/react/src/TextInput/TextInput.tsx | Removes sx and width props from TextInput component and type definitions |
| packages/react/src/TextInput/TextInput.docs.json | Removes documentation for deprecated width-related props |
| packages/react/src/TextInput/TextInput.dev.stories.tsx | Replaces sx prop usage with CSS classes and updates story structure |
| packages/react/src/Select/Select.tsx | Removes sx prop usage from Select component |
| packages/react/src/Overlay/Overlay.features.stories.tsx | Migrates from sx props to CSS modules and semantic components |
| packages/react/src/Overlay/Overlay.features.stories.module.css | Adds CSS module styles to replace inline sx styling |
| .changeset/gold-dingos-sneeze.md | Documents the major version change for removing styled-system usage |
Comments suppressed due to low confidence (1)
packages/react/src/internal/components/TextInputWrapper.tsx:1
- The
styleprop is being destructured from props but removed from the component signature. This will cause the prop to be included inrestPropsand passed to the underlying component, but it's no longer in the type definition. Either remove it from destructuring or add it back to the type definition.
import React, {type ComponentProps} from 'react'
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2381 |
🔴 ci completed with status |
Relates to https://github.com/github/primer/issues/5422
Changelog
New
Changed
Removed
Note
Reviewers: I misunderstood the scope of https://github.com/github/primer/issues/5422 when I started on it and also removed
sxprops. If we want to preserve those for now, I can revert those changes.sxprop fromSelectTextareaTextInputTextInputWithTokensTextInputWrapperwidth,minWidth, andmaxWidthprops fromTextInputWrapperstyled-systemdependenciesRollout strategy
Testing & Reviewing
Merge checklist