Skip to content

feat(FormControl): remove sx - #6951

Merged
francinelucca merged 15 commits into
mainfrom
feat/remove-sx-from-formcontrol
Oct 11, 2025
Merged

feat(FormControl): remove sx#6951
francinelucca merged 15 commits into
mainfrom
feat/remove-sx-from-formcontrol

Conversation

@francinelucca

@francineluccafrancinelucca commented Oct 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Reintroduces #6681 without the subcomponent wrappers since they won't play well with slots

@changeset-bot

changeset-botBot commented Oct 6, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0df4777

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactMajor
@primer/styled-reactMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 6, 2025
@github-actions

github-actionsBot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 6, 2025 12:23 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 6, 2025 12:50 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 6, 2025 13:32 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 6, 2025 17:16 Inactive
@github-actions
github-actionsBot requested a deployment to storybook-preview-6951 October 6, 2025 18:48 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 6, 2025 18:56 Inactive
@primer-integration

primer-integrationBot commented Oct 7, 2025

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3933

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 7, 2025 00:06 Inactive
@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 7, 2025
@francinelucca
francinelucca marked this pull request as ready for review October 7, 2025 00:37
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 8, 2025 16:05 Inactive
@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 8, 2025 16:37 Inactive
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2025
@github-actions

github-actionsBot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

1 similar comment
@github-actions

github-actionsBot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 8, 2025 16:50 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 8, 2025 17:01 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 8, 2025 17:30 Inactive
@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2025
@github-actions

github-actionsBot commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 11, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6951 October 11, 2025 00:57 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Oct 11, 2025
@primer-integration

primer-integrationBot commented Oct 11, 2025

Copy link
Copy Markdown

🔴 ci completed with status failure.

@francinelucca

francinelucca commented Oct 11, 2025

Copy link
Copy Markdown
MemberAuthor

Failure is on main branch, merging https://github.com/github/github-ui/pull/4409

@francinelucca
francinelucca merged commit 2703bc9 into mainOct 11, 2025
42 checks passed
@francinelucca
francinelucca deleted the feat/remove-sx-from-formcontrol branch October 11, 2025 02:25
@primerprimerBot mentioned this pull request Oct 10, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@siddharthkpsiddharthkpsiddharthkp approved these changes

Assignees

No one assigned

Labels

integration-tests: failingChanges in this PR cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@siddharthkp