Skip to content

Fix AnchoredOverlay e2e test button selectors for strict-mode robustness #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix AnchoredOverlay e2e test button selectors for strict-mode robustness #7643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718e3a5
Initial plan
Copilot Mar 9, 2026
556f1c0
fix: use per-story buttonName and .first() in AnchoredOverlay e2e tests
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions e2e/components/AnchoredOverlay.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {themes} from '../test-helpers/themes'
const stories: Array<{
title: string
id: string
buttonName?: string
}> = [
// Default
{
Expand Down Expand Up @@ -59,6 +60,7 @@ const stories: Array<{
{
title: 'Fullscreen Variant',
id: 'components-anchoredoverlay-features--fullscreen-variant',
buttonName: 'Open Fullscreen on Narrow',
},
// Dev
{
Expand Down Expand Up @@ -95,8 +97,9 @@ test.describe('AnchoredOverlay', () => {
})

// Open the overlay
await page.locator('button', {hasText: 'Button'}).waitFor()
await page.getByRole('button', {name: 'Button'}).click()
const buttonName = story.buttonName ?? 'Button'
await page.locator('button', {hasText: buttonName}).first().waitFor()
await page.getByRole('button', {name: buttonName}).first().click()

expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
`AnchoredOverlay.${story.title}.${theme}${namePostfix}.png`,
Expand Down