fix(research): accept event-local evidence cohorts - #160
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughPolymarket evidence aggregation now validates complete 5-minute slots independently within each artifact, allowing gaps between non-overlapping members. Tests, mission policy snapshot identifiers, and the research checklist were updated accordingly. ChangesPolymarket evidence validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 19, 2026
proerror77
force-pushed
the
codex/polymarket-evidence-set-gaps
branch
from
July 19, 2026 16:24
388b732 to
38d674a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Allow a verified Polymarket evidence set to contain non-overlapping time gaps when every member is internally complete; keep overlap and duplicate checks fail-closed.
Out of scope
Collector changes, snapshot compiler APIs, execution logic, and any new data acquisition.
Dependency or merge order
Layer 1 of 4. Merge before #canonical-event and reprice-pilot layers because policy identity includes this verifier source.
Focused validation
git diff --check; targeted set tests added for gap acceptance, overlap/duplicate rejection, and member-local missing-slot rejection. Local Rust compilation was intentionally not run; Linux CI is the build authority.Rollout/rollback impact
Research-only evidence acceptance becomes less global but remains event-local fail-closed. Revert this PR to restore globally contiguous-set enforcement.
Summary by CodeRabbit
Bug Fixes
Configuration
Documentation