fix(research): preserve canonical event cohort boundaries - #161
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 19, 2026
proerror77
force-pushed
the
codex/polymarket-evidence-set-gaps
branch
from
July 19, 2026 16:24
388b732 to
38d674a
Compare
proerror77
force-pushed
the
codex/polymarket-canonical-event-end
branch
from
July 19, 2026 16:25
cc00938 to
f6d641f
Compare
proerror77
changed the base branch from
codex/polymarket-evidence-set-gaps
to
main
July 19, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Bind governed event cohorts to the snapshot canonical event end and reject missing or conflicting canonical ends instead of inferring a fallback.
Out of scope
Reprice pilot execution, collector work, broader mission-schema changes, and live or paper trading.
Dependency or merge order
Layer 2 of 4; base is #160. Merge after #160 and before #162/#163. The checked-in BTC and SOL template policy identities rotate here because the governed source set changes.
Focused validation
git diff --check;cargo fmt --check; targeted counterexample test proves legacy inference would yield rows while governed missing/conflicting canonical ends fail closed. Local Rust compilation was intentionally not run; Linux CI is the build authority.Rollout/rollback impact
Research cohort construction becomes stricter under governance only. Revert restores the prior canonical-end behavior and its matching policy identity.