Skip to content

fix(polymarket): admit complete event-local sparse references - #278

Merged
proerror77 merged 1 commit into
mainfrom
codex/polymarket-event-local-sparse-276
Jul 23, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/polymarket-event-local-sparse-276

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Closes #276

Change contract

Allow only the explicit-market Polymarket evidence normalization/publication path to consume authenticated reference segments with nondecreasing skipped UTC partitions, while retaining every existing event-local completeness and trust-boundary check.

Out of scope

Collector deployment, raw data mutation or cleanup, ResearchSnapshot construction, evaluator/MCTS execution, result publication, standalone selector relaxation, and standalone segment-validator relaxation.

Dependency / merge order

Depends on #273 (merged). Merge this PR before rebuilding the exact-main compiler image and rerunning issue #270 evidence publication.

Focused validation

  • TDD red: sparse complete fixture failed with reference segments must be same or consecutive UTC hours before implementation.
  • Targeted positive/negative tests: event-local normalization accepts a complete 05 -> 07 fixture; public selector and standalone validator still reject it.
  • cargo clippy -p hft-collector --all-targets --features collector-binance --no-deps --locked -- -D warnings
  • cargo test -p hft-collector --features collector-binance --locked (205 library tests passed, 2 ignored; all collector binary tests passed)
  • deployment/aliyun/test-polymarket-raw-ops-control-plane.sh
  • git diff --check

Repository-wide cargo fmt --all --check still reports unrelated pre-existing formatting drift outside these three files; each touched file was formatted directly.

Rollout / rollback impact

Rollout: publish a new exact-main compiler image, then retry only the issue #270 evidence compiler with the authenticated 09/10/11/12/15 reference triplets. Rollback: revert this PR; standalone validation behavior is unchanged.

Matt flow

Approved defect issue -> TDD failing proof -> minimal implementation -> focused/full validation -> code review. A new PRD was unnecessary because #276 already defines one bounded behavior and its acceptance contract.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b92ee35-0d0d-4a64-9c4b-ee149e37b3ea

📥 Commits

Reviewing files that changed from the base of the PR and between 0845694 and fb35450.

📒 Files selected for processing (3)
  • rust_hft/tools/collector/src/polymarket_research_import.rs
  • rust_hft/tools/collector/src/polymarket_research_normalize.rs
  • rust_hft/tools/collector/src/polymarket_research_select.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/polymarket-event-local-sparse-276

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 merged commit 4ac9ecc into main Jul 23, 2026
17 of 18 checks passed
@proerror77
proerror77 deleted the codex/polymarket-event-local-sparse-276 branch July 23, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow sparse reference hours only for complete event-local evidence

1 participant