fix(deploy): gate complete Binance market tape - #296
Conversation
|
Warning Review limit reached
Next review available in: 25 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c06e02e5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| and .snapshot_ready_count == (.snapshot_ready_count | floor) | ||
| and .snapshot_ready_count == .symbol_count | ||
| and .bridged_count == .symbol_count | ||
| and .stream_coverage_verified_count == .symbol_count |
There was a problem hiding this comment.
Preserve rollback compatibility with the previous health schema
When a cutover from the expected pre-#295 production release fails, host-rust-lob-cutover.sh restores the old binary but validates it through the candidate's RUNTIME_HEALTH_POLICY; that older collector does not emit stream_coverage_verified_count or all_stream_coverage_verified. Consequently, wait_for_release_health times out and the rollback path disables and runtime-masks the restored production units, turning a recoverable candidate failure into a collection outage. Use a policy compatible with the old release when verifying rollback, or a separate backward-compatible rollback predicate.
AGENTS.md reference: AGENTS.md:L86-L88
Useful? React with 👍 / 👎.
2d16f54 to
c74b787
Compare
6c06e02 to
506c174
Compare
506c174 to
aa41015
Compare
Relates to #224.
Change contract: Require the ECS shadow gate and release policy to prove continuous canonical binance.market_tape.v1 segments with real agg_trade rows, exact stream coverage, complete static-or-diff LOB continuity, manifest/data SHA and _SUCCESS integrity before collector cutover.
Out of scope: Producer/runtime code (merged #295), verifier/data contract (merged #293), historical reconstruction, snapshot construction, evaluator/MCTS, research logic, Polymarket collection, and the cutover operation itself.
Dependency or merge order: #293 and #295 are merged. This PR is retargeted to main and is the final deployment/gate layer. No production cutover before this layer is merged and a fresh full ECS gate passes. Rollback order is this PR, then #295, then #293.
Focused validation:
Rollout/rollback impact: After merge, build and install a SHA-addressed candidate on the existing ECS, run the isolated one-hour full-catalog gate, and cut over only if the immutable PASS evidence proves at least two post-observation segments per market, agg_trade > 0 per segment, exact stream coverage, zero sequence gaps/rollbacks, and canonical SHA/_SUCCESS readback. A failed gate leaves the current production binary active. Roll back this layer before producer layer #295.
PRD note: This is the deployment portion of the already-approved issue #224 contract; a separate PRD is unnecessary.