fix(collector): align Binance segment rotation - #301
Conversation
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Relates to #224.
Change contract: Align Binance collector segment duration rotation to UTC epoch boundaries so the ten-minute shadow configuration cannot rotate once at start+600s and immediately again at the hourly partition boundary, producing a checkpoint-only technical segment with no real aggregate trade.
Out of scope: Relaxing the agg_trade > 0 gate, deployment/gate policy changes, ECS cutover, historical reconstruction, snapshot construction, evaluator/MCTS, research logic, Polymarket collection, and any production-unit change.
Dependency or merge order: #293, #295, and #296 are merged. This focused runtime follow-up must merge before building the next candidate and rerunning the full one-hour #224 gate.
Focused validation:
Rollout/rollback impact: Build a new SHA-addressed candidate, install it without touching production, and rerun the unchanged full gate. A failed gate leaves the existing production binary active. Rollback is the single collector commit in this PR.
PRD note: This is a small, already-specified runtime defect discovered by the #224 production gate; focused TDD is sufficient and no new PRD is needed.