Skip to content

test(research): assert logical snapshot digest wire - #371

Merged
proerror77 merged 1 commit into
mainfrom
codex/snapshot-admission-wire-test-370
Jul 26, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/snapshot-admission-wire-test-370

Conversation

@proerror77

@proerror77 proerror77 commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Change contract

Correct the snapshot-admission success-wire test to assert the actual 16-character lowercase logical digest.

Acceptance evidence

  • cargo test -q -p ploy-research --features db --bin monday-prediction-snapshot tests::snapshot_admission_protocol_success_wire_has_only_admitted_identities -- --exact (1 passed)
  • cargo fmt --check -p ploy-research
  • git diff --check

Out of scope

Admission protocol behavior, dispatch, pipeline smoke, collector deployment, and production configuration.

Dependency / merge order

Independent follow-up to merged #364; may merge before #323.

Rollout / rollback impact

Test-only correction; no runtime behavior changes.

Summary by CodeRabbit

  • Tests
    • Updated snapshot admission validation to reflect the new digest format.
    • Added verification that snapshot digests are lowercase hexadecimal strings with 16 characters.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 05e3e80b-feb3-4604-b504-465a6fbb12ef

📥 Commits

Reviewing files that changed from the base of the PR and between c9646f8 and 45df786.

📒 Files selected for processing (1)
  • rust_hft/prediction-markets/crates/ploy-research/src/bin/monday-prediction-snapshot.rs

📝 Walkthrough

Walkthrough

The snapshot admission protocol test now uses a 16-character lowercase hexadecimal snapshot_digest and validates it separately from fields requiring a sha256: prefix.

Changes

Snapshot digest validation

Layer / File(s) Summary
Update snapshot digest assertions
rust_hft/prediction-markets/crates/ploy-research/src/bin/monday-prediction-snapshot.rs
The fabricated response uses the new digest format, while dedicated assertions require exactly 16 lowercase hexadecimal characters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • proerror77/monday#370 — Describes the same update to validate snapshot_digest as a 16-character lowercase hexadecimal value.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the test-only snapshot digest assertion change.
Description check ✅ Passed The description covers the main template sections and validation evidence, with only minor heading mismatches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/snapshot-admission-wire-test-370

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 merged commit a105ac5 into main Jul 26, 2026
38 checks passed
@proerror77
proerror77 deleted the codex/snapshot-admission-wire-test-370 branch July 26, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant