fix(research): preserve checkpoint float identity - #429
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR enables exact ChangesPrediction policy and checkpoint precision
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract: Enable exact f64 JSON roundtrips for ploy-research checkpoint state and atomically refresh the governed policy identity and BTC/SOL mission pins so a freshly written checkpoint survives typed readback.
Out of scope: Checkpoint schema, evaluator semantics, cohort or projection logic, collector/runtime, hft-search-kernel, CEX, alpha-harness, and the #325 E2E fixture.
Dependency / merge order: This is the sole predecessor to #325. Merge #428 first; only then rebase and promote #325.
Focused validation:
TDD note: A PRD is unnecessary because this is a small, already-specified defect. The counterexample proves that -1.9089014592447406 changed one ULP under the prior serde_json feature graph and now preserves exact to_bits identity.
Rollout / rollback impact: Dependency-feature-only research correctness change. Rollback restores the known false corruption rejection for valid checkpoint metrics and requires reverting the refreshed policy graph and mission pins atomically.
Closes #428
Summary by CodeRabbit
Configuration
Reliability
Tests