Skip to content

fix(monitor): make collector checks fail closed - #762

Merged
proerror77 merged 1 commit into
mainfrom
codex/collector-monitor-truth-738
Aug 9, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/collector-monitor-truth-738

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Send a valid multiline Cloud Assistant health script and make an unhealthy or unverifiable collector-host check fail the workflow after its deduplicated alert is recorded.

Issue relationship

Refs #738

Out of scope

Credential/RAM changes, pre-health prerequisite alerting, collector or timer changes, production mutation, and unrelated deployment work.

Dependencies and merge order

None

Focused validation

  • .github/scripts/test-monitor-collector-host.sh reproduces literal \\n payload bytes and missing terminal failure on the old workflow, then passes after the fix.
  • The contract test is wired into the existing ploy/workflow-lint job.
  • .github/scripts/test-select-rust-ci-scope.sh passes and confirms workflow/script changes select that lane.
  • ShellCheck, Actionlint for both changed workflows, Ruby YAML parse, and git diff --check pass.
  • Counterexample: ok:true skips the final failure step; ok:false and invocation uncertainty alert first, then fail the job.

Rollout and rollback

No collector-host mutation. After merge, the next scheduled run must yield an InvokeId and decoded health snapshot; keep #738 open until that live readback. Roll back by reverting this commit.

Scope exception

None

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b679826-7a3b-4b7e-9b18-a1c07a7148e3

📥 Commits

Reviewing files that changed from the base of the PR and between 1210d51 and a3c36df.

📒 Files selected for processing (3)
  • .github/scripts/test-monitor-collector-host.sh
  • .github/workflows/monitor-collector-host.yml
  • .github/workflows/ploy-ci.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97a721c720

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/monitor-collector-host.yml
@proerror77
proerror77 enabled auto-merge (squash) August 9, 2026 02:36
@proerror77
proerror77 disabled auto-merge August 9, 2026 02:37
@proerror77
proerror77 force-pushed the codex/collector-monitor-truth-738 branch from 97a721c to 286aac9 Compare August 9, 2026 02:39
@proerror77
proerror77 force-pushed the codex/collector-monitor-truth-738 branch from 286aac9 to a3c36df Compare August 9, 2026 02:41
@proerror77
proerror77 merged commit 5dc3855 into main Aug 9, 2026
47 checks passed
@proerror77
proerror77 deleted the codex/collector-monitor-truth-738 branch August 9, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant