fix(monitor): make collector checks fail closed - #762
Conversation
|
Warning Review limit reached
Next review available in: 38 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97a721c720
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
97a721c to
286aac9
Compare
286aac9 to
a3c36df
Compare
Change contract
Send a valid multiline Cloud Assistant health script and make an unhealthy or unverifiable collector-host check fail the workflow after its deduplicated alert is recorded.
Issue relationship
Refs #738
Out of scope
Credential/RAM changes, pre-health prerequisite alerting, collector or timer changes, production mutation, and unrelated deployment work.
Dependencies and merge order
None
Focused validation
.github/scripts/test-monitor-collector-host.shreproduces literal\\npayload bytes and missing terminal failure on the old workflow, then passes after the fix.ploy/workflow-lintjob..github/scripts/test-select-rust-ci-scope.shpasses and confirms workflow/script changes select that lane.git diff --checkpass.ok:trueskips the final failure step;ok:falseand invocation uncertainty alert first, then fail the job.Rollout and rollback
No collector-host mutation. After merge, the next scheduled run must yield an
InvokeIdand decoded health snapshot; keep #738 open until that live readback. Roll back by reverting this commit.Scope exception
None