fix(monitor): use Aliyun OIDC credentials - #766
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe monitor collector workflow now uses GitHub OIDC to obtain temporary Aliyun credentials. Repository variables define the provider and role. A validation script checks the required OIDC configuration and rejects static AccessKeys. ChangesMonitor collector OIDC migration
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/scripts/test-monitor-collector-host.sh:
- Around line 20-23: Expand the matcher in the workflow credential check to
reject any `aliyun configure` usage, the `--access-key-id` and
`--access-key-secret` CLI flags, and standard Alibaba Cloud AccessKey
environment names in addition to the existing patterns. Keep the failure
behavior through `oidc_contract_failed=1` unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: eb776d05-53ee-456f-8fde-be9e705c3457
📒 Files selected for processing (2)
.github/scripts/test-monitor-collector-host.sh.github/workflows/monitor-collector-host.yml
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74b4f326db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
74b4f32 to
7475364
Compare
Change contract
Authenticate the collector-host monitor through GitHub OIDC and the pinned official Aliyun credential action, yielding temporary STS credentials for the existing CLI calls without long-lived AccessKeys.
Issue relationship
Refs #738
Out of scope
Provisioning or changing the Aliyun OIDC provider, RAM role, trust policy, or cloud permissions; configuring repository variables; deleting existing repository secrets; changing the target instance, region, Cloud Assistant command, health semantics, gate, cutover, or production runtime.
Dependencies and merge order
PR #762 is merged. Before this workflow runs from main,
ALIYUN_COLLECTOR_MONITOR_OIDC_PROVIDER_ARNandALIYUN_COLLECTOR_MONITOR_ROLE_ARNrepository variables must identify an already-provisioned trust and role restricted to the documented instance and Cloud Assistant operations. Missing or rejected OIDC configuration fails the job closed.Focused validation
bash .github/scripts/test-monitor-collector-host.shbash .github/scripts/test-select-rust-ci-scope.shshellcheck .github/scripts/test-monitor-collector-host.sh.github/workflows/monitor-collector-host.ymlactionlintfor monitor and Prediction Markets workflowsgit diff --check origin/main...HEADRollout and rollback
No cloud or production mutation in this PR. Merge changes authentication on the next scheduled/manual monitor run. Revert this commit to roll back the code path; do not weaken the existing fail-closed health behavior.
Scope exception
None.