fix(alpha): isolate blocking mission execution - #88
Conversation
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change contract
Run only
mission executeon a Tokio blocking worker so its synchronous HTTP, filesystem, database, and archive pipeline cannot create or drop blocking runtimes on the async dispatcher thread, while preserving the inner error chain.Out of scope
Dependency or merge order
None. This PR is based directly on current
main. Merge before the independent prediction-runner PR only to avoid overlappingcli.rsrebases; there is no behavioral dependency.Focused validation
cargo +1.91 fmt --manifest-path rust_hft/Cargo.toml --package alpha-harness -- --checkCARGO_BUILD_JOBS=2 cargo +1.91 test --manifest-path rust_hft/Cargo.toml --locked -p alpha-harness(72 passed)CARGO_BUILD_JOBS=2 cargo +1.91 clippy --manifest-path rust_hft/Cargo.toml --locked -p alpha-harness --all-targets -- -D warningscli::tests::mission_execute_runs_blocking_pipeline_outside_async_runtimeexercisesmission executeunder a current-thread Tokio runtime and verifies the original inner source error survives worker dispatch.Rollout / rollback impact
Research CLI scheduling only. Mission output, validation, and fail-closed behavior are unchanged. Roll back by reverting this PR; no schema, data, deployment, or live-execution migration is involved.