Skip to content

fix(alpha): isolate blocking prediction pipelines - #90

Merged
proerror77 merged 1 commit into
mainfrom
codex/prediction-blocking-runner
Jul 17, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/prediction-blocking-runner

Conversation

@proerror77

@proerror77 proerror77 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Change contract

Run prediction execute and prediction snapshot on Tokio blocking workers so their synchronous HTTP, filesystem, archive, and subprocess pipelines cannot block or create/drop blocking runtimes on the async dispatcher thread, while preserving inner error chains.

Out of scope

  • Mission execution dispatch, which merged independently in fix(alpha): isolate blocking mission execution #88.
  • Prediction research semantics, snapshot contents, cost modeling, live execution, collectors, or broader async refactors.
  • New runtime configuration or dependencies; this only enables the already-installed Tokio sync feature for test serialization.

Dependency or merge order

#88 merged first to avoid an overlapping cli.rs rebase. This PR is now based directly on current main and has no remaining behavioral or stacked dependency.

Focused validation

  • cargo +1.91 fmt --manifest-path rust_hft/Cargo.toml --package alpha-harness -- --check
  • CARGO_BUILD_JOBS=2 cargo +1.91 test --manifest-path rust_hft/Cargo.toml --locked -p alpha-harness (74 passed)
  • CARGO_BUILD_JOBS=2 cargo +1.91 clippy --manifest-path rust_hft/Cargo.toml --locked -p alpha-harness --all-targets -- -D warnings
  • Targeted counterexamples run both prediction commands under a current-thread Tokio runtime. Execute preserves the missing-source error; snapshot reaches the blocking HTTP client then preserves the occupied immutable-result error.
  • Scope: 2 files, 125 additions, 3 deletions.

Rollout / rollback impact

Research CLI scheduling only. Prediction artifacts, validation, immutable publication, and fail-closed behavior are unchanged. Roll back by reverting this PR; no schema, data, deployment, or live-execution migration is involved.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cab3a88c-a532-495a-85fa-bd7e94c126b9

📥 Commits

Reviewing files that changed from the base of the PR and between 04d548c and 0c1cde4.

📒 Files selected for processing (2)
  • rust_hft/alpha-harness/app/Cargo.toml
  • rust_hft/alpha-harness/app/src/cli.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/prediction-blocking-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread rust_hft/alpha-harness/app/src/cli.rs Fixed
@proerror77
proerror77 force-pushed the codex/prediction-blocking-runner branch from 67882e6 to 0c1cde4 Compare July 17, 2026 09:46
@proerror77
proerror77 merged commit 3aaf49b into main Jul 17, 2026
30 checks passed
@proerror77
proerror77 deleted the codex/prediction-blocking-runner branch July 17, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants