Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jan 19, 2018. It is now read-only.
Fail if unable to find artifact - #556
Merged
Merged
Conversation
| artifact_paths.append(dir_child_path) | ||
| else: | ||
| raise NuleculeException("Unable to find artifact %s" % path) | ||
Contributor
There was a problem hiding this comment.
so right now we only raise an exception if the file or dir doesn't exist. what happens if they pass us a directory but the directory is empty? Should that be an error?
cdrageforce-pushed
the
fail-if-file-not-found
branch
from
February 16, 2016 14:58
d587307 to
c058de0Comparecdrage
commented
Feb 16, 2016
MemberAuthor
PR updated to include if directory is empty. |
| continue | ||
| artifact_paths.append(dir_child_path) | ||
| elif os.listdir(path) == []: | ||
| raise NuleculeException("Artifact directory %s is empty" % path) |
Contributor
There was a problem hiding this comment.
this is dead code. If it is a directory the it will pass the 2nd if and won't ever get to the 3rd one right?
cdrageforce-pushed
the
fail-if-file-not-found
branch
from
February 18, 2016 16:21
c058de0 to
8df8b1cComparecdrage
commented
Feb 18, 2016
MemberAuthor
Hey @dustymabe I updated it, don't know if it's to your satisfaction, hopefully it's better 👍 |
cdrageforce-pushed
the
fail-if-file-not-found
branch
from
February 18, 2016 16:23
8df8b1c to
5f621d5Comparedustymabe
commented
Feb 19, 2016
Contributor
LGTM. rebase and merge please |
dustymabe
commented
Feb 19, 2016
Contributor
@cdrage ^^ |
cdrageforce-pushed
the
fail-if-file-not-found
branch
from
February 22, 2016 16:50
5f621d5 to
0b9b580Comparecdrage
commented
Feb 22, 2016
MemberAuthor
Rebased and unit/integration tests pass. Mergin' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2nd half of #532, raises NuleculeException if unable to find a file.
Another PR ahead for failing when using a wrong inherited provider, (ex. providing inherit: foobar).