Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jan 19, 2018. It is now read-only.
Fix xpathing tests on missing files - #557
Merged
Merged
Conversation
dustymabe
commented
Feb 15, 2016
Contributor
LGTM. rebase and merge please |
dustymabe
commented
Feb 15, 2016
Contributor
Actually I don't know if this is right. First off, it doesn't actually make the tests pass when testing on top of the commit in #556. In the test file for this we create a temporary directory but never do anything with it. I don't see any other tests that use a tmp dir, they use the examples dir directly. Should we not be doing the same thing? If I update the test to point to the example dir ( |
cdrage
commented
Feb 16, 2016
MemberAuthor
Yeah, you're right. Let's switch from tmp files to use an explicit example (pref helloapache). I'll fix this. Do not merge for now. |
cdrageforce-pushed
the
fix-xpathing-checks
branch
from
February 16, 2016 15:08
e3e65dc to
870c678Comparecdrage
commented
Feb 16, 2016
MemberAuthor
@dustymabe Updated 👍 |
dustymabe
commented
Feb 16, 2016
Contributor
LGTM merging |
dustymabe added a commit
that referenced
this pull request
Feb 16, 2016
Fix xpathing tests on missing files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be merged before #556
Fixes tests on xpathing files due to missing artifacts. Making #556 error out on tests due to missing files.