Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n and validation (#77) - Updated XML documentation in LanguageTag.cs to clarify return values and parsing behavior. - Enhanced LanguageTagBuilder methods to specify that they set subtags without validation. - Improved normalization and validation methods in LanguageTagParser to ensure null checks are handled properly. - Added remarks in LogOptions to clarify the effects of setting logger factory and logger after creation. - Streamlined async file handling in Rfc5646Data to use 'using' statements for better resource management. - Updated tests to inherit from SingleInstanceFixture for consistent test execution and resource management. - Refined exception handling in Program.cs to ensure proper logging and cleanup on errors. - General code cleanup and consistency improvements across various files. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the LanguageTags library to follow standardized patterns across projects, with significant breaking changes to the public API.
Changes:
- Renamed async methods to follow the
Frompattern (e.g.,LoadDataAsync()→FromDataAsync()) - Simplified logging configuration to use static
LogOptions.SetFactory(ILoggerFactory)instead of per-instance options - Streamlined API by removing
Optionsparameter overloads throughout the codebase - Updated documentation across README, HISTORY, CODESTYLE, AGENTS, and copilot-instructions files
- Modernized code with cleaner
usingstatements and pattern matching - Added comprehensive test coverage for new
Frompattern methods
Reviewed changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated documentation for breaking changes, new API patterns, and simplified logging configuration |
| LanguageTagsTests/*.cs | Updated tests to use FromDataAsync/FromJsonAsync, added new test cases, inherited from SingleInstanceFixture |
| LanguageTagsTests/Fixture.cs | Refactored to use AssemblyFixture pattern and SingleInstanceFixture base class |
| LanguageTagsTests/.editorconfig | Added suppressions for test-specific diagnostics |
| LogOptionsTests.cs | Simplified tests to match new static-only logging configuration |
| LanguageTags/Options.cs | Removed entire file (Options class no longer needed) |
| LanguageTags/LogOptions.cs | Simplified to static-only configuration, removed instance logger support |
| LanguageTags/Rfc5646Data.cs | Changed to instance methods for loading, added FromDataAsync/FromJsonAsync static factories |
| LanguageTags/Iso6393Data.cs | Changed to instance methods for loading, added FromDataAsync/FromJsonAsync static factories |
| LanguageTags/Iso6392Data.cs | Changed to instance methods for loading, added FromDataAsync/FromJsonAsync static factories |
| LanguageTags/LanguageTag.cs | Removed Options parameter overloads, updated documentation |
| LanguageTags/LanguageTagParser.cs | Simplified to remove Options support, modernized pattern matching |
| LanguageTags/LanguageTagBuilder.cs | Removed Options parameter overloads, improved documentation |
| LanguageTags/LanguageLookup.cs | Changed from primary constructor with Options to lazy logger initialization |
| LanguageTags/LanguageSchema.cs | Removed unused WriteFileAsync method |
| LanguageTags/Extensions.cs | Updated extension method calls to non-static pattern |
| LanguageTagsCreate/Program.cs | Added exception handling and logger cleanup |
| LanguageTagsCreate/LoggerFactory.cs | Improved logger creation with better defaults |
| LanguageTagsCreate/CreateTagData.cs | Updated to use new FromDataAsync methods and simplified argument validation |
| LanguageTagsCreate/HttpClientFactory.cs | Simplified pattern matching for HTTP result checking |
| HISTORY.md | Documented breaking changes for version 1.2 |
| CODESTYLE.md | Updated documentation guidelines and testing framework reference |
| AGENTS.md | Updated API documentation to reflect new patterns |
| .github/copilot-instructions.md | Comprehensive update to reflect all API changes |
| .editorconfig | Minor cleanup and added ReSharper settings |
| LanguageTags.code-workspace | Added dictionary entries, removed deprecated extension |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.