Reference AGENTS.md's Unresolved-Rule Line Instead of Copying It - #1074
Conversation
local-strict-review/SKILL.md's subagent-briefing template restated AGENTS.md's own closing line verbatim; point at it instead so it can't drift out of sync. Regenerated the two mirrored copies via build_dist.py.
PR Summary by QodoReference canonical unresolved-rule guidance in local strict review
AI Description
Diagram
High-Level Assessment
Files changed (4) |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe three mirrored ChangesLocal strict review briefing
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk:⚪ Minimal · up to This change removes duplicated template wording and references the authoritative rule instead, keeping the canonical and mirrored documentation aligned; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The pull request removes the copied unresolved-rule wording and replaces it with an AGENTS.md reference in the canonical skill and both mirrored copies. The source digest was also updated. This satisfies issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Review by Qodo
1. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
🟡 Changes recommended
The new guidance that replaces the removed template line is outside the fenced brief block and can be missed when the block is copied, leaving the subagent brief shape incomplete.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the local-strict-review skill to avoid duplicating (and potentially drifting from) the canonical “unresolved rule” closing line in AGENTS.md, then regenerates the mirrored skill distributions.
Changes:
- Removed the verbatim unresolved-rule closing sentence from the
local-strict-reviewsubagent-brief template block. - Added a prose instruction to reference
AGENTS.md’s canonical template line instead of restating it. - Regenerated mirrored copies under
.github/skills/and.claude-plugin/fleet-skills/(including updating.source-digest).
File summaries
| File | Description |
|---|---|
| .agents/skills/local-strict-review/SKILL.md | Canonical skill source updated to stop verbatim-copying the unresolved-rule line. |
| .github/skills/local-strict-review/SKILL.md | Regenerated mirror reflecting the canonical skill change. |
| .claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md | Regenerated mirror reflecting the canonical skill change. |
| .claude-plugin/fleet-skills/.source-digest | Updated digest for the regenerated fleet-skills distribution. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CodeRabbit caught a copy-paste completeness gap: the round-1 fix moved the unresolved-rule pointer entirely outside the fenced template, so pasting just the fence dropped it. Moved the reference back inside the fence, phrased to point at AGENTS.md rather than restate its wording.
ptr727
commented
Aug 29, 2026
Qodo finding "PR title lacks Title Case": fixed, title changed to "Reference AGENTS.md's Unresolved-Rule Line Instead of Copying It" (Title Case). Qodo's own badge already shows this struck through as outdated. |
There was a problem hiding this comment.
🔵 Needs a closer look
The new template line reads as if it includes AGENTS.md's closing sentence, but it is only a reference, so it should be reworded for unambiguous prompting.
Review details
Suppressed comments (3)
.agents/skills/local-strict-review/SKILL.md:52
- The new line says to "Close with" AGENTS.md's unresolved-rule closing line, but this text is only a reference to that line. Reword to make it clear the template ends with a reference (not the closing sentence itself), to avoid ambiguity for someone copy/pasting this block as a subagent prompt.
Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation
Discipline", referenced rather than restated here.
.github/skills/local-strict-review/SKILL.md:52
- The new line says to "Close with" AGENTS.md's unresolved-rule closing line, but this text is only a reference to that line. Reword to make it clear the template ends with a reference (not the closing sentence itself), to avoid ambiguity for someone copy/pasting this block as a subagent prompt.
Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation
Discipline", referenced rather than restated here.
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md:52
- The new line says to "Close with" AGENTS.md's unresolved-rule closing line, but this text is only a reference to that line. Reword to make it clear the template ends with a reference (not the closing sentence itself), to avoid ambiguity for someone copy/pasting this block as a subagent prompt.
Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation
Discipline", referenced rather than restated here.
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
ptr727
commented
Aug 29, 2026
Qodo suppressed finding (3x, one per mirror, ".../SKILL.md:52"): "the new line says to 'Close with' AGENTS.md's unresolved-rule closing line, but this text is only a reference to that line ... reword to make it clear the template ends with a reference (not the closing sentence itself)." Declined: the fence already establishes this exact instructional pattern one line earlier, verbatim, line 45: "Rules that bind this task: quote |
Uh oh!
There was an error while loading. Please reload this page.
Your rationale is sound. The wording at lines 51–52 follows the established line-45 convention: it instructs the instantiated prompt to include external text, rather than treating the reference itself as literal output. The reported concern is therefore not actionable; the corresponding Qodo finding is already marked outdated (finding 1). |
Follow-up to #1074 (issue #1070), found by the develop -> main promotion PR (#1077)'s own review. Copilot sharpened Qodo's earlier ambiguity finding on the same line: the closing-reference sentence sat inside the fenced subagent-brief template with no field-name prefix, unlike the template's other five fields (Task/Paths/Rules that bind this task/Return/Bounds), so it read as literal content handed to the subagent rather than an instruction to whoever assembles the brief — and the subagent has no access to `AGENTS.md` to resolve it. Fix: gave it its own `Close:` field, phrased the same way line 45 already resolves the identical pattern (inserting canonical content into the prompt at assembly time rather than restating it): `quote X into the prompt`. Ran `local-strict-review` against this branch's diff before pushing; no blocking findings (one purely stylistic comma-splice nit, not a rule violation, left as-is). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated review guidance to require quoting the exact unresolved-rule closing line, “Context and Delegation Discipline,” rather than referring to it indirectly. * Synchronized the same instruction across all distributed review guidance. * Refreshed associated source metadata to reflect the updated guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Follow-up to #1074/#1079 (issue #1070), found by the develop -> main promotion PR (#1077)'s second review round. Copilot flagged the `Close:` field #1079 introduced as a non-canonical key: `AGENTS.md`'s own template ("Context and Delegation Discipline") has exactly 5 labeled fields (Task/Paths/Rules that bind this task/Return/Bounds) followed by one unlabeled trailing sentence, not a 6th labeled field. `local-strict-review/SKILL.md`'s own "Running It" section says to follow that exact shape. Round 1 fix (commit 2778010): dropped the `Close:` label, went back to an unlabeled trailing line in the same position `AGENTS.md`'s own closing sentence occupies, kept #1079's "quote X into the prompt" phrasing. A fresh Copilot round then flagged that this still read as an imperative instruction addressed to the subagent, who cannot fulfil it (no AGENTS.md access) - the same ambiguity #1079 had already addressed once. Round 2 fix (commit 2faa0e0, current): replaced the imperative sentence with an explicit angle-bracket placeholder, matching `AGENTS.md`'s own template syntax exactly (which uses `<...>` for every field value). This is the second use of that convention in this file, not a new one - `<target>` already appears the same way at line 40. Fails safe if pasted unsubstituted: an obvious unfilled token rather than a misleading instruction. Ran `local-strict-review` against this branch's diff before each push, explicitly asked to hunt for a reason a further round could still be needed. Round 2's review: no confirmed defect, and a specific, honest assessment of why this shape is unlikely to bounce again (matches an established in-file convention, fails safe, closes every prior round's concern simultaneously).
Fixes#1070.
local-strict-review/SKILL.md's subagent-briefing template copied the closing sentence ofAGENTS.md's own template ("If a rule you were given does not cover what you find, stop and report it. Do not guess, and do not read a governance file to resolve it.") verbatim into its fenced instantiation, instead of only referencing it. That risks silent drift ifAGENTS.md's template wording changes later.Fix: dropped the copied line from the fenced template block, added one prose sentence outside the fence pointing at
AGENTS.md's own template line instead. Applied to the canonical source (.agents/skills/local-strict-review/SKILL.md) and regenerated the two mirrored copies (.claude-plugin/fleet-skills/,.github/skills/) viascripts/build_dist.py.Ran
local-strict-reviewagainst this branch's own diff before pushing (dogfooding it, per the issue's own subject): it confirmed the fix's core claim (the referenced line is verbatim-present inAGENTS.md) and caught one real prose-convention slip — the new sentence was hard-wrapped across two physical lines, the one paragraph in the file breaking its own single-line-per-paragraph convention (.markdownlint-cli2.jsoncdisables MD013 deliberately for this file's long-paragraph style). Fixed before this push.scripts/build_dist.py --check,scripts/prose_lint.py,scripts/repo_gate.py, andscripts/host_gate.pyall pass.Summary by CodeRabbit
Documentation
Chores