Give the Closing-Reference Line Its Own Template Field by ptr727 · Pull Request #1079 · ptr727/ProjectTemplate

ptr727 · 2026-08-29T03:05:09Z

Follow-up to #1074 (issue #1070), found by the develop -> main promotion PR (#1077)'s own review.

Copilot sharpened Qodo's earlier ambiguity finding on the same line: the closing-reference sentence sat inside the fenced subagent-brief template with no field-name prefix, unlike the template's other five fields (Task/Paths/Rules that bind this task/Return/Bounds), so it read as literal content handed to the subagent rather than an instruction to whoever assembles the brief — and the subagent has no access to AGENTS.md to resolve it.

Fix: gave it its own Close: field, phrased the same way line 45 already resolves the identical pattern (inserting canonical content into the prompt at assembly time rather than restating it): quote X into the prompt.

Ran local-strict-review against this branch's diff before pushing; no blocking findings (one purely stylistic comma-splice nit, not a rule violation, left as-is).

Summary by CodeRabbit

Documentation
- Updated review guidance to require quoting the exact unresolved-rule closing line, “Context and Delegation Discipline,” rather than referring to it indirectly.
- Synchronized the same instruction across all distributed review guidance.
- Refreshed associated source metadata to reflect the updated guidance.

Copilot's review of the develop -> main promotion PR (#1077) sharpened Qodo's earlier ambiguity finding: the closing-reference sentence sat inside the fenced brief with no field-name prefix, unlike the template's other five fields, so it read as literal content handed to the subagent instead of an instruction to whoever assembles the brief. Gave it a "Close:" field, phrased the same way line 45 already resolves the identical insert-canonical-content-at-assembly-time pattern ("quote X into the prompt").

qodo-code-review · 2026-08-29T03:05:35Z

PR Summary by Qodo

Add a Close Field to the Strict Review Brief Template

📝 Documentation⚙️ Configuration changes🕐 Less than 10 minutes

AI Description

• Adds an explicit Close field for injecting the canonical unresolved-rule line.
• Prevents assemblers from treating the closing instruction as literal subagent content.
• Synchronizes distributed skill copies and the Claude plugin source digest.

Diagram

graph TD
A["Source Skill"] -->|syncs| B["Claude Skill"] -->|fingerprints| C["Source Digest"]
A -->|syncs| D["GitHub Skill"]

High-Level Assessment

The chosen approach is optimal: naming the line Close makes its assembly-time role consistent with the surrounding fields, while referencing canonical AGENTS.md text avoids duplicating policy that could drift. Synchronizing both distributed copies and the digest preserves packaging consistency.

Files changed (4) +7 / -7

Documentation (3) +6 / -6

SKILL.mdName the canonical closing instruction as a template field+2/-2

Name the canonical closing instruction as a template field

• Adds a 'Close:' field to the subagent brief template and explicitly directs the assembler to quote the unresolved-rule closing line from 'AGENTS.md'. This distinguishes assembly guidance from literal content intended for the subagent.

.agents/skills/local-strict-review/SKILL.md

SKILL.mdSynchronize the Close field into the Claude skill copy+2/-2

Synchronize the Close field into the Claude skill copy
• Mirrors the explicit 'Close:' field and canonical quoting instruction in the Claude plugin distribution.
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md

SKILL.mdSynchronize the Close field into the GitHub skill copy+2/-2

Synchronize the Close field into the GitHub skill copy
• Mirrors the explicit 'Close:' field and canonical quoting instruction in the GitHub-distributed skill.
.github/skills/local-strict-review/SKILL.md

Other (1) +1 / -1

.source-digestRefresh the Claude fleet-skills source digest+1/-1

Refresh the Claude fleet-skills source digest
• Updates the source digest to account for the synchronized local-strict-review skill content.
.claude-plugin/fleet-skills/.source-digest

coderabbitai · 2026-08-29T03:05:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 43716ad1-85ec-43ce-82e3-7950c7659b0f

📥 Commits

Reviewing files that changed from the base of the PR and between 5117355 and aca3f27.

📒 Files selected for processing (4)

.agents/skills/local-strict-review/SKILL.md
.claude-plugin/fleet-skills/.source-digest
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md
.github/skills/local-strict-review/SKILL.md

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

Walkthrough

The strict-review prompts now require an exact quotation of AGENTS.md’s “Context and Delegation Discipline” line. The change applies to local, plugin, and GitHub skill copies. The source digest is updated.

Changes

Strict-review prompt synchronization

Layer / File(s)	Summary
Align prompt wording and source digest `.agents/skills/local-strict-review/SKILL.md`, `.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md`, `.github/skills/local-strict-review/SKILL.md`, `.claude-plugin/fleet-skills/.source-digest`	The strict-review prompts now require quoting the exact unresolved-rule closing line from `AGENTS.md`. The source digest value is updated.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk:⚪ Minimal · up to aca3f

This localized template wording change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main objective: giving the closing-reference line its own template field.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/1070-followup-close-field

_{Comment @coderabbitai help to get the list of available commands.}

qodo-code-review · 2026-08-29T03:06:15Z

Code Review by Qodo

🐞 Bugs (0)📘 Rule violations (0)📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Copilot

🟢 Approval recommended

The change is a small, consistent documentation/template clarification applied uniformly across the canonical source and its generated mirrors.

Pull request overview

Clarifies the local-strict-review subagent-brief template by giving the closing-reference instruction its own explicit Close: field, making it consistent with the other template fields and reducing ambiguity about what is literal brief content versus assembler-time guidance.

Changes:

Replaces the prior unkeyed closing-reference sentence with a dedicated Close: field instructing the assembler to quote the canonical unresolved-rule closing line from AGENTS.md.
Applies the same change across the canonical skill source and both mirrored distributions, updating the fleet-skills source digest accordingly.

File summaries

File	Description
.github/skills/local-strict-review/SKILL.md	Adds an explicit `Close:` field to the subagent-brief template for clarity/consistency.
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md	Mirrors the `Close:` field change into the Claude plugin distribution copy.
.claude-plugin/fleet-skills/.source-digest	Updates the distribution digest to match the regenerated content.
.agents/skills/local-strict-review/SKILL.md	Updates the canonical skill source template with the new `Close:` field.

Review details

Files reviewed: 4/4 changed files
Comments generated: 0
Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Follow-up to #1074/#1079 (issue #1070), found by the develop -> main promotion PR (#1077)'s second review round. Copilot flagged the `Close:` field #1079 introduced as a non-canonical key: `AGENTS.md`'s own template ("Context and Delegation Discipline") has exactly 5 labeled fields (Task/Paths/Rules that bind this task/Return/Bounds) followed by one unlabeled trailing sentence, not a 6th labeled field. `local-strict-review/SKILL.md`'s own "Running It" section says to follow that exact shape. Round 1 fix (commit 2778010): dropped the `Close:` label, went back to an unlabeled trailing line in the same position `AGENTS.md`'s own closing sentence occupies, kept #1079's "quote X into the prompt" phrasing. A fresh Copilot round then flagged that this still read as an imperative instruction addressed to the subagent, who cannot fulfil it (no AGENTS.md access) - the same ambiguity #1079 had already addressed once. Round 2 fix (commit 2faa0e0, current): replaced the imperative sentence with an explicit angle-bracket placeholder, matching `AGENTS.md`'s own template syntax exactly (which uses `<...>` for every field value). This is the second use of that convention in this file, not a new one - `<target>` already appears the same way at line 40. Fails safe if pasted unsubstituted: an obvious unfilled token rather than a misleading instruction. Ran `local-strict-review` against this branch's diff before each push, explicitly asked to hunt for a reason a further round could still be needed. Round 2's review: no confirmed defect, and a specific, honest assessment of why this shape is unlikely to bounce again (matches an established in-file convention, fails safe, closes every prior round's concern simultaneously).

CopilotAI lite review requested due to automatic review settings August 29, 2026 03:05

Copilotstarted reviewing on behalf of ptr727 August 29, 2026 03:05 View session

CopilotAI reviewed Aug 29, 2026
View reviewed changes

ptr727 merged commit bbc9b8f into developAug 29, 2026
9 checks passed

ptr727 deleted the feature/1070-followup-close-field branch August 29, 2026 03:08

ptr727 mentioned this pull request Aug 29, 2026
Drop the Close Field, Match AGENTS.md's Own Unlabeled Shape #1080
Merged

ptr727 mentioned this pull request Aug 29, 2026
Prose-only fixes for skill-trigger reliability keep proving insufficient - decide where hooks belong #1083
Open

Navigation Menu

Give the Closing-Reference Line Its Own Template Field - #1079

Give the Closing-Reference Line Its Own Template Field#1079
ptr727 merged 1 commit into
developfrom
feature/1070-followup-close-field

ptr727 commented Aug 29, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

qodo-code-reviewBot commented Aug 29, 2026

Uh oh!

coderabbitaiBot commented Aug 29, 2026•
edited
Loading

Walkthrough

Changes

Uh oh!

qodo-code-reviewBot commented Aug 29, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Aug 29, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

qodo-code-reviewBot commented Aug 29, 2026

PR Summary by Qodo

Uh oh!

coderabbitaiBot commented Aug 29, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

qodo-code-reviewBot commented Aug 29, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptr727 commented Aug 29, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Aug 29, 2026•
edited
Loading