Write upstream-version state file as CRLF to honor the JSON rule by ptr727 · Pull Request #172 · ptr727/ProjectTemplate

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

ptr727 · 2026-06-21T21:33:55Z

Closes#170. Supersedes #171 (which took the wrong approach — see below).

Problem

check-upstream-version-task.yml wrote the state file with printf '%s\n' on the runner — LF — but .editorconfig defaults .json/.jsonc to CRLF. The committed upstream-version.json therefore contradicted the repo's own rule: open it in an .editorconfig-aware (or vanilla Windows) editor and save, and it flips to CRLF, so the next tracker run rewrites it back to LF — a spurious Canonicalize upstream version state file PR.

Why not carve the file out to LF (the closed#171 / issue option 2)

The whole point of defaulting JSON to CRLF is that Windows vanilla-editor saves don't break things. Carving the state file out to LF inverts that — a Windows save produces CRLF and now violates the carve-out, churning on exactly the platform the CRLF rule protects. So the fix belongs in the task, not in a special case.

Fix (issue option 1)

Write the state file with CRLF, honoring .editorconfig's rule for .json with no per-file carve-out. jq emits LF, so convert line endings on write:

printf'%s\n'"$new"| sed 's/$/\r/'>"$STATE_FILE"

.editorconfig and .gitattributes are untouched.

Validation

Output is CRLF (file → JSON text data, cat -A → ^M$ line ends) and idempotent: rewriting identical content is byte-for-byte identical, so no churn / no spurious PR.
jq -S '.' still round-trips the CRLF file, so the old-state read and union diff are unaffected (comparison is on parsed objects, EOL-agnostic).
A Windows vanilla-editor save now produces CRLF that matches the committed file.
YAML parses.

🤖 Generated with Claude Code

check-upstream-version-task wrote the state file LF, but .editorconfig defaults .json to CRLF (so Windows vanilla-editor saves don't churn). The LF output contradicted that rule: a CRLF save flipped the file and the next run rewrote it to LF, a spurious canonicalize bump. Write CRLF instead (jq emits LF; convert on write), matching the rule with no per-file carve-out. Closes#170 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates the reusable check-upstream-version-task.yml workflow to write the upstream version state JSON file using CRLF line endings, aligning the workflow output with the repository's .editorconfig rule for *.json and preventing churn/spurious PRs caused by LF/CRLF flips.

Changes:

Convert jq's LF output to CRLF when writing the committed upstream-version.json (or configured state-file) to match .editorconfig.
Update the inline workflow comment to document why CRLF is required for the state file and how the conversion is done.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170.

* Adopt canonical upstream-version tracker for multi-key state Replace the bespoke check-esphome-version.yml with the carried check-upstream-version-task.yml plus a thin scheduled entry-point (check-upstream-version.yml) whose resolver prints the esphome and device-builder versions as a JSON object. Rename the state file esphome-version.json -> upstream-version.json (keyed esphome and device_builder, sorted JSON) and point build-docker-task.yml, the merge-bot refs (upstream-version-<base>), and the PR paths-filter at it. Converges on ptr727/ProjectTemplate#169, which added structured multi-key state to the canonical task per the gap filed in #168. Closes#66. * Write upstream-version state file as CRLF per template fix Re-sync the carried check-upstream-version-task.yml to write the state file as CRLF (jq emits LF), honoring .editorconfig's .json rule, and convert upstream-version.json to CRLF to match. Converges on ptr727/ProjectTemplate#172, which resolved the LF-vs-CRLF state-file nuance filed in #170. * Harden upstream resolver curl error reporting Add --show-error/--location to the PyPI curl calls and emit ::error:: annotations on resolve failure, so a failed scheduled run surfaces a clear cause. Addresses Copilot review feedback on PR #67. * Use product names in resolver errors and tracker wording Reference ESPHome and esphome-device-builder (the PyPI/product names) in the resolve-failure messages, and update the remaining "ESPHome-version bump" mention in AGENTS.md to "upstream-version bump". Addresses Copilot review feedback on PR #67.

… quota (#180) Promote accumulated `develop` work to `main` so derived repos can re-sync from `main` (the stable ref) rather than tracking `develop`. Docs / CI / config only — no `version.json` bump (no functional change). ## Notable contents - **Consolidate code style + carry contract** (#178, closes#175): one root `CODESTYLE.md` (General → .NET → Python, droppable sections); `PyPiLibrary/CODESTYLE.md` removed; `CODESTYLE.md` + `.vscode/tasks.json` added to the verbatim-carry list; official-tooling casing (`.Net*` → `.NET*`); clean-compile rule; brownfield/suppression scope hierarchy; `dependsOrder: sequence` on the `.NET Format` task. - **Clarify project-rule home + harden Copilot runbook** (#173): project conventions/API contracts live in `AGENTS.md`, not `.github/copilot-instructions.md`; a no-inline-comment review is a clean pass; poll for the auto-review before self-triggering. - **Cut Actions artifact-storage quota usage** (#179): PR smoke builds no longer upload artifacts nothing consumes. - Plus prior develop work: docs/comment cleanup (#167), `check-upstream-version-task` structured multi-key state (#169) + CRLF state file (#172), `publish-docker-readme-task`, and routine codegen updates. ## Notes - develop → main is **merge-commit only** (preserves develop's commit list as a second-parent reference on `main`). - Merging closes#173 and #175 (their `Closes` keywords reach the default branch). - After merge, the downstream re-sync issues (each updated with the current state) can point at `main`.

CopilotAI review requested due to automatic review settings June 21, 2026 21:33

Copilotstarted reviewing on behalf of ptr727 June 21, 2026 21:34 View session

Trim state-file write comment
d14c090
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

CopilotAI reviewed Jun 21, 2026
View reviewed changes

ptr727 requested a review from Copilot June 21, 2026 22:07

Copilotstarted reviewing on behalf of ptr727 June 21, 2026 22:07 View session

CopilotAI reviewed Jun 21, 2026
View reviewed changes

ptr727 merged commit 38f46ea into developJun 21, 2026
9 checks passed

ptr727 deleted the upstream-version-state-crlf branch June 21, 2026 22:12

ptr727 mentioned this pull request Jun 21, 2026
check-upstream-version-task writes LF state file but .editorconfig defaults .json to CRLF #170
Closed

ptr727 mentioned this pull request Jun 21, 2026
Adopt canonical upstream-version tracker for multi-key state ptr727/ESPHome-NonRoot#67
Merged

ptr727 mentioned this pull request Jun 22, 2026
Promote develop to main: CODESTYLE consolidation, Copilot runbook, CI quota #180
Merged