Conversation
## Summary - Trigger the Python code-style skill when selecting or running Python verification commands. - Require repository-specific verification guidance before substituting generic commands. - Distinguish build-profile pytest from lint-only unittest execution. - Regenerate the GitHub Copilot and Claude Code skill distributions. ## Why The previous trigger covered Python edits and pytest authoring, but not running tests. That gap allowed a generic pytest invocation in this lint-only repository and produced a false missing-dependency diagnosis. ## Verification - `uvx coverage@latest run --source=scripts,spec,host-setup -m unittest discover -s scripts/tests` (727 tests passed) - `python3 scripts/tests/test_build_dist.py` (25 tests passed) - `python3 scripts/build_dist.py --check` - Diff-scoped prose and sentence-length checks - EOL and diff checks - markdownlint-cli2 (158 files, 0 issues)
## Summary - Make pull request creation start the review loop by default. - Require a foreground review status read followed by a bounded background wait. - Continue through findings, fixes, replies, resolution, and re-review until green. - Permit stopping or altering the loop only on explicit maintainer instruction. - Expand the skill trigger and AGENTS routing so the rule fires when a PR opens. - Regenerate the GitHub Copilot and Claude Code skill distributions. ## Why The review-loop procedure was correct after it started, but neither the skill trigger nor the PR-creation handoff required it to start. An agent could therefore open a draft PR, report the URL, and stop before requesting or monitoring review. ## Verification - `uvx coverage@latest run --source=scripts,spec,host-setup -m unittest discover -s scripts/tests` (727 tests passed) - `python3 scripts/tests/test_build_dist.py` (25 tests passed) - `python3 scripts/build_dist.py --check` - Diff-scoped prose and sentence-length checks - EOL and diff checks - markdownlint-cli2 (158 files, 0 issues)
## Summary - prepare Husky.Net hook runtimes when a task worktree is created - prepare Python pre-commit hooks through the repository's declared environment - keep repository-specific hook setup authoritative and prohibit hook bypasses - regenerate the carried Copilot and Claude skill distributions ## Why Fresh worktrees contain tracked hook configuration but omit generated runtimes such as `.husky/_/husky.sh`. A first commit can therefore fail even when the clone-level hook path is configured. Worktree preparation now installs supported hook runtimes before the first commit. ## Verification - full `OPERATIONS.md` local verification chain - 727 unit tests - audit and write-guard self-tests - generated skill distribution consistency - repository and prose gates - JSON and spec validation - editorconfig-checker, ShellCheck, and PSScriptAnalyzer
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the current guidance from develop by updating the fleet governance and reviewer-skill distributions, adding explicit worktree hook-prep steps and tightening the default PR review loop contract.
Changes:
- Expand
GOVERNANCE.mdPR review etiquette to explicitly include PR opening, bounded wait usage, and the “no silent early exit” rule. - Add “Preparing Git Hooks” guidance to the
repo-worktreeskill (Husky.Net and Python pre-commit) across all distributed skill copies. - Update
python-codestyleandpr-review-conductskill wording to emphasize readingOPERATIONS.mdand treating PR creation as the start of the review loop, then sync those updates into downstream skill bundles.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GOVERNANCE.md | Clarifies the PR review-loop contract and explicitly frames PR creation as the start of the loop. |
| AGENTS.md | Updates the rules router description to include “opening a pull request” under PR review etiquette. |
| .github/skills/repo-worktree/SKILL.md | Adds hook-runtime preparation steps to new worktree setup guidance. |
| .github/skills/python-codestyle/SKILL.md | Adds “read OPERATIONS.md first” guidance and clarifies the lint-only profile’s test/tooling expectations. |
| .github/skills/pr-review-conduct/SKILL.md | Expands the trigger/loop description to include PR opening and bounded wait usage. |
| .claude-plugin/fleet-skills/skills/repo-worktree/SKILL.md | Mirrors the repo-worktree updates into the Claude plugin distribution. |
| .claude-plugin/fleet-skills/skills/python-codestyle/SKILL.md | Mirrors the python-codestyle updates into the Claude plugin distribution. |
| .claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md | Mirrors the pr-review-conduct updates into the Claude plugin distribution. |
| .claude-plugin/fleet-skills/.source-digest | Updates the plugin source digest to reflect the regenerated distribution. |
| .agents/skills/repo-worktree/SKILL.md | Mirrors the repo-worktree updates into the agents skill distribution. |
| .agents/skills/python-codestyle/SKILL.md | Mirrors the python-codestyle updates into the agents skill distribution. |
| .agents/skills/pr-review-conduct/SKILL.md | Mirrors the pr-review-conduct updates into the agents skill distribution. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developbranch tomainrepo-worktreeskill to downstream Copilot reviewersVerification
Closesptr727/PhotoCleaner#61