Uh oh!
There was an error while loading. Please reload this page.
ci: include Boost - #2393
Merged
Merged
Conversation
EricCousineau-TRI
commented
Aug 14, 2020
Collaborator
Er, just to check, what was the motivation for this? (issue number, or Slack convo?) I'm watching paint dry in #2376, and it seems like the Boost download can take 1m - 3m in different Mac builds: |
EricCousineau-TRI
commented
Aug 14, 2020
Collaborator
Ah, benchmarking, gotcha! |
henryiii
commented
Aug 14, 2020
CollaboratorAuthor
I think it also tests boost::variant (probably v1 and not v2). We might be able to cache homebrew. |
CollaboratorAuthor
We can drop macOS Boost, and leave Boost only for unix/Windows (since they don't plan to add Boost to the macOS image). |
EricCousineau-TRI
commented
Aug 14, 2020
Collaborator
Aye. Submitted naive PR: #2395 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Boost to the CI checks.