Skip to content

ci: Remove "Setup Boost (macOS)" step - #2395

Merged
henryiii merged 1 commit into
pybind:masterfrom
EricCousineau-TRI:feature-mac-ci-no-boost
Aug 14, 2020
Merged

ci: Remove "Setup Boost (macOS)" step#2395
henryiii merged 1 commit into
pybind:masterfrom
EricCousineau-TRI:feature-mac-ci-no-boost

Conversation

@EricCousineau-TRI

@EricCousineau-TRIEricCousineau-TRI commented Aug 14, 2020

Copy link
Copy Markdown
Collaborator

Per convo: #2393 (comment) - slows down the macOS builds for very little gain.

@henryiii

Copy link
Copy Markdown
Collaborator

I miss GitLab's merge when checks pass option. :'(

@EricCousineau-TRI

Copy link
Copy Markdown
CollaboratorAuthor

Ooh, hadn't seen that in GitLab! But yeah, that would be awesome in cases like these...

@YannickJadoul

YannickJadoul commented Aug 14, 2020

Copy link
Copy Markdown
Collaborator

We tried out https://github.com/apps/probot-auto-merge on cibuildwheel, at some point. It's ... yeah, a replacement, but there should be a better way.

(For the record; nothing with a minimal amount of approves - really not a fan of setting that up - but just a label to add that will merge on green.)

@henryiii
henryiii merged commit 5a3ff72 into pybind:masterAug 14, 2020
@henryiii

Copy link
Copy Markdown
Collaborator

Did that work well enough?

@YannickJadoul

Copy link
Copy Markdown
Collaborator

It seems so: pypa/cibuildwheel#383 It worked, but it's maybe a bit weird to have this bot merge it, rather than it just being a feature of the platform...

@bstaletic

Copy link
Copy Markdown
Collaborator

https://mergify.io/ seems like an alternative to probot-auto-merge.

@henryiiihenryiii added the ci related to the CI system label Aug 18, 2020
@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cirelated to the CI system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@EricCousineau-TRI@henryiii@YannickJadoul@bstaletic