Uh oh!
There was an error while loading. Please reload this page.
CI for smart holders as default - #2930
Conversation
4876b24 to
88f3474Comparerhaschke
commented
Apr 7, 2021
cmake implicitly sets |
f207165 to
2417d9dCompare
rwgk
left a comment
There was a problem hiding this comment.
I really like that it's so easy, but I'm also really worried about introducing two copies of something so substantial. @henryiii, is there an obvious way to avoid the duplication?
Naive idea: have a small patch file somewhere else, and a bash script that applies that patch to generate this file, with a big comment at the top: "This is an auto-generated file, do not edit." And another comment with instructions how to run the bash script. — But I hope Henry knows of something more organized.
I tried to merge the new SH builds into the existing |
rwgk
commented
Apr 20, 2021
The work here was included in #2963. Closing. Thanks Robert! |
This adds another CI workflow enabling
PYBIND11_USE_SMART_HOLDER_AS_DEFAULT