Uh oh!
There was an error while loading. Please reload this page.
Connecting PYBIND11_INTERNALS_VERSION to PYBIND11_USE_SMART_HOLDER_AS_DEFAULT. - #2939
Conversation
rwgk
commented
Apr 6, 2021
@rhaschke the github web UI won't let me add you as a reviewer, I have no idea why. Tagging you here instead. |
rwgk
commented
Apr 6, 2021
#2879 is used for testing with |
| #pragma once | ||
| #include "../pytypes.h" | ||
| #include "smart_holder_sfinae_hooks_only.h" |
There was a problem hiding this comment.
This is your approach to define PYBIND11_USE_SMART_HOLDER_AS_DEFAULT?
Why don't you use a compiler definition?
There was a problem hiding this comment.
Initially mainly to have an easy way to run the CI with smart_holder as default. But then I thought it's good to keep as an option, to give people an easy way to experiment using smart_holder as default without having to go into their cmake/CI/IDE/whatever they may have. As-is, it works both ways. I'm reluctant to take one option away, especially because the cost is just a few extra lines in smart_holder_sfinae_hooks_only.h. With pytypes.h included first here, everything else is included already anyway.
There was a problem hiding this comment.
I wasn't asking to remove that option. I was just wondering. For CI, I suggest to use the cmake argument option to allow both checks to run on the same code base. I'm still struggling with some issues in #2930 though... But, I'm optimistic 😄
There was a problem hiding this comment.
Oh, good, thanks! And yes, it'll be awesome to trigger all testing with just one PR.
rhaschke
commented
Apr 7, 2021
You can only tag people as a reviewer that are part of the maintainer team. |
Uh oh!
There was an error while loading. Please reload this page.
d353b45 to
4b9bc48Compare…ybind#2939. For compatibility with PR pybind#3275.
Extensions built with
PYBIND11_USE_SMART_HOLDER_AS_DEFAULTdefined are incompatible with extensions built against master, orPYBIND11_USE_SMART_HOLDER_AS_DEFAULTundefined, thereforePYBIND11_INTERNALS_VERSIONneeds to be different. The approach chosen here is to add1000to thePYBIND11_INTERNALS_VERSIONon master.