Skip to content

[smart_holder] Introducing PYBIND11_INTERNALS_SH_DEF. - #3283

Merged
rwgk merged 1 commit into
pybind:smart_holderfrom
rwgk:internals_sh_def
Sep 20, 2021
Merged

[smart_holder] Introducing PYBIND11_INTERNALS_SH_DEF.#3283
rwgk merged 1 commit into
pybind:smart_holderfrom
rwgk:internals_sh_def

Conversation

@rwgk

@rwgkrwgk commented Sep 20, 2021

Copy link
Copy Markdown
Collaborator

In hindsight, this is clearly the better approach.

@rwgkrwgk changed the title Introducing PYBIND11_INTERNALS_SH_DEF.[smart_holder] Introducing PYBIND11_INTERNALS_SH_DEF.Sep 20, 2021
@rwgk

rwgk commented Sep 20, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Hi @charlesbeattie, could you please help reviewing this small change (smart_holder branch)?
It was tested already via the helper/scratch PR #3282, GitHub CI & Google-internally.

(The CI-SH-DEF pypy3 macos-latest failure is a flake: occasional download issue.)

@charlesbeattie

Copy link
Copy Markdown
Contributor

Looks good to me.

@rwgk

rwgk commented Sep 20, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Thanks @charlesbeattie!

I clicked through all 5 CI failures, they are all intermittent macos brew boost download issues. I'll ignore those, especially because this change was already tested PR #3282.

@rwgk
rwgk merged commit b08b849 into pybind:smart_holderSep 20, 2021
@rwgk
rwgk deleted the internals_sh_def branch September 20, 2021 12:54
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Sep 20, 2021
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Sep 20, 2021
@rwgkrwgk mentioned this pull request Sep 20, 2021
@rwgkrwgk mentioned this pull request Feb 10, 2023
rwgk added a commit to rwgk/pybind11 that referenced this pull request Feb 14, 2024
rwgk added a commit that referenced this pull request Feb 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@charlesbeattie