Skip to content

tests: check simple iteration of pairs - #3296

Merged
henryiii merged 1 commit into
pybind:masterfrom
henryiii:henryiii/tests/iter
Sep 23, 2021
Merged

tests: check simple iteration of pairs#3296
henryiii merged 1 commit into
pybind:masterfrom
henryiii:henryiii/tests/iter

Conversation

@henryiii

@henryiiihenryiii commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

Description

Adding a few tests that break under #3271 but work currently. If we had coverage testing, the fact these overloads were never tested might have been discovered.

Suggested changelog entry:

Just tests.

Comment threadtests/test_sequences_and_iterators.cpp Outdated
@henryiii
henryiii merged commit 5f46e47 into pybind:masterSep 23, 2021
@henryiii
henryiii deleted the henryiii/tests/iter branch September 23, 2021 12:01
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Sep 23, 2021
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Sep 23, 2021
@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@henryiii