Uh oh!
There was an error while loading. Please reload this page.
fix: iteration of non-copyable - #3297
Closed
henryiii wants to merge 3 commits into
Closed
Conversation
henryiiiforce-pushed
the
henryiii/fix/itercopy
branch
from
September 23, 2021 04:37
2d75d7d to
599f26fCompareCollaboratorAuthor
Unrelated, but not sure why updating Catch2 isn't working, seems here https://packages.msys2.org/package/mingw-w64-x86_64-catch?repo=mingw64 that it's available in the correct version. |
henryiii
commented
Sep 24, 2021
CollaboratorAuthor
(Implemented in #3293, except for the Catch2 update) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making just the fix in #3271. Seeing if this passes more compilers by avoiding the bigger changes. Builds on #3296.
Suggested changelog entry:
* Fix ``make_key_iterator()`` to return references instead of copies.WIP: I've actually dropped the key part at the moment, seeing what compiles where.