Uh oh!
There was an error while loading. Please reload this page.
Final manual curation in preparation for global clang-formating - #3712
Conversation
| ssize_t itemsize = 0; // Size of individual items in bytes | ||
| ssize_t size = 0; // Total number of entries | ||
| std::string format; // For homogeneous buffers, this should be set to format_descriptor<T>::format() | ||
| std::string format; // For homogeneous buffers, this should be set to |
There was a problem hiding this comment.
FWIW, for these sorts of things, I'd do something like:
<empty line>
// Comment
std::string thing;
That will format much better, remain readable, and use less horizontal space for some extra vertical space.
No need to do that now. But that would be my general solution.
There was a problem hiding this comment.
I was going back and forth myself exactly here, then decided clang-format is actually doing a very nice job, preserving the original intent (no semi-pun intended). It's not obvious here, but if you look under #3713 it's great there. — But I'm happy to change it around. What do you prefer? Put only some comments on top, as needed? Or all, systematically?
There was a problem hiding this comment.
Let's go with that then. Merge at your discretion.
| // Placeholder type for the unneeded (and dead code) static variable in the | ||
| // PYBIND11_OVERRIDE_OVERRIDE macro | ||
| struct override_unused {}; |
Very labor-intensive and dull.
Description
After this PR is merged we are ready for the last fully-automatic step: PR #3713.
Informed by experimental work under #3708, which is this PR + clang-format in pre-commit.
Suggested changelog entry: