Skip to content

chore(clang-tidy): Add missing clang-tidy fixes - #3715

Merged
rwgk merged 1 commit into
pybind:masterfrom
Skylion007:fix-missing-clang-tidy
Feb 10, 2022
Merged

chore(clang-tidy): Add missing clang-tidy fixes#3715
rwgk merged 1 commit into
pybind:masterfrom
Skylion007:fix-missing-clang-tidy

Conversation

@Skylion007

Copy link
Copy Markdown
Collaborator

Description

  • The recent clang-tidy fixes did not have full coverage because of various ifdefs. I ran clang-tidy on my local machine and found lots of errors. Adding the fixes in this PR. We may want to use cmake to run clang-tidy on every CI to catch this or at least have the clang-tidy config use the debug config.

@rwgk

rwgk commented Feb 10, 2022

Copy link
Copy Markdown
Collaborator

Awesome, thanks for catching this! I'll merge this now to get this into #3712 & #3713.

For later: clang-tidy is very slow unfortunately, running in every CI could be a drag. Maybe 4 total: (clang, gcc) x (NDEBUG yes/no)?

@rwgk
rwgk merged commit dc9803c into pybind:masterFeb 10, 2022
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Feb 10, 2022
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Feb 10, 2022
@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Skylion007@rwgk