Skip to content

feat: add entrypoint for cmake modules dir - #4258

Merged
henryiii merged 1 commit into
pybind:masterfrom
henryiii:henryiii/feat/entrypoint
Oct 20, 2022
Merged

feat: add entrypoint for cmake modules dir#4258
henryiii merged 1 commit into
pybind:masterfrom
henryiii:henryiii/feat/entrypoint

Conversation

@henryiii

@henryiiihenryiii commented Oct 19, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This can be used by tools (like scikit-build-core) to access the cmake modules directory. Suggested use:

module_dirs=importlib.metadata.entry_points(group="cmake.modules")
dirs= (importlib.resources.files(ep.load()) forepinmodule_dirs)
paths_str=";".join(str(p) forpindirs)
cmake_arg=f"-DCMAKE_PREFIX_PATH={paths_str}"

Suggested changelog entry:

* Experimental support for ``cmake.modules`` entrypoint.

@henryiii
henryiiiforce-pushed the henryiii/feat/entrypoint branch 2 times, most recently from cbcd269 to adeea8fCompareOctober 19, 2022 21:13
@henryiii
henryiiiforce-pushed the henryiii/feat/entrypoint branch from adeea8f to 5177f73CompareOctober 20, 2022 12:55
@henryiiihenryiii mentioned this pull request Oct 20, 2022
Closed
@henryiii
feat: add entrypoint for cmake modules dir
7893bab
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiiiforce-pushed the henryiii/feat/entrypoint branch from 5177f73 to 7893babCompareOctober 20, 2022 13:56
@henryiii
henryiii merged commit 1d4a65e into pybind:masterOct 20, 2022
@henryiii
henryiii deleted the henryiii/feat/entrypoint branch October 20, 2022 14:35
@henryiiihenryiii added the needs changelog Possibly needs a changelog entry label Oct 20, 2022
henryiii added a commit to henryiii/pybind11 that referenced this pull request Oct 20, 2022
@henryiii
feat: add entrypoint for cmake modules dir (pybind#4258)
412918d
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
@henryiiihenryiii mentioned this pull request Oct 21, 2022
Closed
henryiii added a commit that referenced this pull request Oct 21, 2022
@henryiii
Revert "feat: add entrypoint for cmake modules dir (#4258)"
bd7a9c4
This reverts commit 1d4a65e.
@henryiiihenryiii mentioned this pull request Oct 21, 2022
Merged
henryiii added a commit that referenced this pull request Oct 21, 2022
@henryiii
Revert "feat: add entrypoint for cmake modules dir" (#4270)
91cfb77
* Revert "feat: add entrypoint for cmake modules dir (#4258)"
This reverts commit 1d4a65e.
* docs: revert changelog mention too
henryiii added a commit to henryiii/pybind11 that referenced this pull request Oct 21, 2022
@henryiii
Revert "feat: add entrypoint for cmake modules dir" (pybind#4270)
eaa5f7b
* Revert "feat: add entrypoint for cmake modules dir (pybind#4258)"
This reverts commit 1d4a65e.
* docs: revert changelog mention too
@rwgkrwgk mentioned this pull request Feb 11, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007Skylion007Skylion007 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryiii@Skylion007