Skip to content

feat: add entrypoint for cmake modules dir#4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryiii merged 1 commit into from
Oct 20, 2022
Merged

feat: add entrypoint for cmake modules dir #4258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ def remove_output(*sources: str) -> Iterator[None]:
stdout=sys.stdout,
stderr=sys.stderr,
)
if not global_sdist:
Path("pybind11/share/cmake/pybind11/__init__.py").touch()

txt = get_and_replace(setup_py, version=version, extra_cmd=extra_cmd)
code = compile(txt, setup_py, "exec")
Expand Down
2 changes: 2 additions & 0 deletions tests/extra_python_package/test_files.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def test_build_sdist(monkeypatch, tmpdir):
files |= {f"pybind11{n}" for n in local_sdist_files}
files.add("pybind11.egg-info/entry_points.txt")
files.add("pybind11.egg-info/requires.txt")
files.add("pybind11/share/cmake/pybind11/__init__.py")
assert simpler == files

with open(os.path.join(MAIN_DIR, "tools", "setup_main.py.in"), "rb") as f:
Expand DownExpand Up@@ -252,6 +253,7 @@ def tests_build_wheel(monkeypatch, tmpdir):
"dist-info/entry_points.txt",
"dist-info/top_level.txt",
}
files.add("pybind11/share/cmake/pybind11/__init__.py")

with zipfile.ZipFile(str(wheel)) as z:
names = z.namelist()
Expand Down
3 changes: 3 additions & 0 deletions tools/setup_main.py.in
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,9 @@ setup(
],
"pipx.run": [
"pybind11 = pybind11.__main__:main",
],
"cmake.modules": [
"pybind11 = pybind11.share.cmake.pybind11",
]
},
cmdclass=cmdclass
Expand Down