Uh oh!
There was an error while loading. Please reload this page.
bugfix: Keep registered types until after Py_Finalize(). Fix #4459 - #4486
Merged
Skylion007 merged 2 commits intoFeb 6, 2023
Merged
Conversation
rwgk
approved these changes
Feb 2, 2023
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
I'm OK to let the testing slip, in the interest of getting the fix in sooner rather than later, but it would be best to mention that clearly in the PR description, e.g.:
TODO / help wanted: unit test exercising the atexit situation.
| // Local internals contains data managed by the current interpreter, so we must clear them to | ||
| // avoid undefined behaviors when initializing another interpreter | ||
| // Must be cleared after Py_Finalize() so atexit and other hooks can use registered_types |
Collaborator
There was a problem hiding this comment.
// Must be cleared only after Py_Finalize() so atexit and other hooks can still use use registered_types
?
Extra "only" and "still", to emphasize the importance.
rwgk added a commit
to rwgk/pybind11
that referenced
this pull request
Feb 8, 2023
…ybind#4459 (pybind#4486)" This reverts commit b2c1978. See pybind#4500 for background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NOTE: rolled back with PR #4501
Fix#4459 . Keep types registered until after atexit is called.
TODO / help wanted: unit test exercising the atexit situation.
Suggested changelog entry: