Skip to content

Revert PR #4486 (until we understand the segfault under PR #4500) - #4501

Merged
rwgk merged 1 commit into
pybind:masterfrom
rwgk:rollback_pr4459
Feb 8, 2023
Merged

Revert PR #4486 (until we understand the segfault under PR #4500)#4501
rwgk merged 1 commit into
pybind:masterfrom
rwgk:rollback_pr4459

Conversation

@rwgk

@rwgkrwgk commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

This reverts commit b2c1978.

See #4500 for background.

Description

Suggested changelog entry:

@rwgk
rwgk marked this pull request as ready for review February 8, 2023 00:29
@rwgk
rwgk requested a review from Skylion007February 8, 2023 00:30
@rwgk

rwgk commented Feb 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Thanks Aaron!

@rwgk
rwgk merged commit f8713ec into pybind:masterFeb 8, 2023
@rwgk
rwgk deleted the rollback_pr4459 branch February 8, 2023 00:55
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Feb 8, 2023
@rwgkrwgk changed the title Revert PR #4459 (until we understand the segfault under PR #4500)Revert PR #4486 (until we understand the segfault under PR #4500)Feb 8, 2023
@rwgk

rwgk commented Feb 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Sorry, I had the PR number wrong, I just changed the title of this PR to point back to #4486.

@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Feb 8, 2023
@rwgkrwgk mentioned this pull request Feb 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@Skylion007