Skip to content

Deprecate allow_lazy - #3435

Merged
dcherian merged 17 commits into
pydata:masterfrom
dcherian:fix/allow_lazy
Nov 13, 2019
Merged

Deprecate allow_lazy#3435
dcherian merged 17 commits into
pydata:masterfrom
dcherian:fix/allow_lazy

Conversation

@dcherian

Copy link
Copy Markdown
Contributor

@dcherian

dcherian commented Oct 22, 2019

Copy link
Copy Markdown
ContributorAuthor

This is a breaking change though the previous behaviour could also be considered a bug since we were computing dask arrays by default.

@crusaderkycrusaderky mentioned this pull request Oct 22, 2019
12 tasks
@dcherian

Copy link
Copy Markdown
ContributorAuthor

@shoyer what do you think of this aggressive deprecation strategy (i.e.treating the current behaviour as a bug and deprecating explicit uses of allow_lazy)?

@shoyer

Copy link
Copy Markdown
Member

Works for me!

dcherianand others added 7 commits October 24, 2019 08:27
* upstream/master:
minor lint tweaks (pydata#3429)
Hack around pydata#3440 (pydata#3442)
Update Terminology page to account for multidimensional coordinates (pydata#3410)
Use cftime master for upstream-dev build (pydata#3439)
* upstream/master: (27 commits)
drop_vars; deprecate drop for variables (pydata#3475)
uamiv test using only raw uamiv variables (pydata#3485)
Optimize dask array equality checks. (pydata#3453)
Propagate indexes in DataArray binary operations. (pydata#3481)
python 3.8 tests (pydata#3477)
__dask_tokenize__ (pydata#3446)
Type check sentinel values (pydata#3472)
Fix typo in docstring (pydata#3474)
fix test suite warnings re `drop` (pydata#3460)
Fix integrate docs (pydata#3469)
Fix leap year condition in monthly means example (pydata#3464)
Hypothesis tests for roundtrip to & from pandas (pydata#3285)
unpin cftime (pydata#3463)
Cleanup whatsnew (pydata#3462)
enable xr.ALL_DIMS in xr.dot (pydata#3424)
Merge stable into master (pydata#3457)
upgrade black verison to 19.10b0 (pydata#3456)
Remove outdated code related to compatibility with netcdftime (pydata#3450)
Remove deprecated behavior from dataset.drop docstring (pydata#3451)
jupyterlab dark theme (pydata#3443)
...
@dcherian

Copy link
Copy Markdown
ContributorAuthor

Now with tests!

ready for review & merge.

Comment threaddoc/whats-new.rst Outdated
Comment threadxarray/core/variable.py Outdated
dcherianand others added 5 commits November 12, 2019 15:37
Co-Authored-By: Mathias Hauser <mathause@users.noreply.github.com>
Co-Authored-By: Mathias Hauser <mathause@users.noreply.github.com>
* upstream/master:
add missing pint integration tests (pydata#3508)
DOC: update bottleneck repo url (pydata#3507)
add drop_sel, drop_vars, map to api.rst (pydata#3506)
remove syntax warning (pydata#3505)
Dataset.map, GroupBy.map, Resample.map (pydata#3459)
tests for datasets with units (pydata#3447)
fix pandas-dev tests (pydata#3491)
unpin pseudonetcdf (pydata#3496)
whatsnew corrections (pydata#3494)
@dcherian

Copy link
Copy Markdown
ContributorAuthor

Thanks @mathause! I'll merge tomorrow if there are no comments.

@max-sixty

Copy link
Copy Markdown
Collaborator

LGTM!

@dcherian
dcherian merged commit 94525bb into pydata:masterNov 13, 2019
@dcherian
dcherian deleted the fix/allow_lazy branch November 13, 2019 15:48
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 14, 2019
* upstream/master:
Allow appending datetime & boolean variables to zarr stores (pydata#3504)
warn if dim is passed to rolling operations. (pydata#3513)
Deprecate allow_lazy (pydata#3435)
Recursive tokenization (pydata#3515)
format indexing.rst code with black (pydata#3511)
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 17, 2019
* upstream/master:
Added fill_value for unstack (pydata#3541)
Add DatasetGroupBy.quantile (pydata#3527)
ensure rename does not change index type (pydata#3532)
Leave empty slot when not using accessors
interpolate_na: Add max_gap support. (pydata#3302)
units & deprecation merge (pydata#3530)
Fix set_index when an existing dimension becomes a level (pydata#3520)
add Variable._replace (pydata#3528)
Tests for module-level functions with units (pydata#3493)
Harmonize `FillValue` and `missing_value` during encoding and decoding steps (pydata#3502)
FUNDING.yml (pydata#3523)
Allow appending datetime & boolean variables to zarr stores (pydata#3504)
warn if dim is passed to rolling operations. (pydata#3513)
Deprecate allow_lazy (pydata#3435)
Recursive tokenization (pydata#3515)
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 17, 2019
* upstream/master: (22 commits)
Added fill_value for unstack (pydata#3541)
Add DatasetGroupBy.quantile (pydata#3527)
ensure rename does not change index type (pydata#3532)
Leave empty slot when not using accessors
interpolate_na: Add max_gap support. (pydata#3302)
units & deprecation merge (pydata#3530)
Fix set_index when an existing dimension becomes a level (pydata#3520)
add Variable._replace (pydata#3528)
Tests for module-level functions with units (pydata#3493)
Harmonize `FillValue` and `missing_value` during encoding and decoding steps (pydata#3502)
FUNDING.yml (pydata#3523)
Allow appending datetime & boolean variables to zarr stores (pydata#3504)
warn if dim is passed to rolling operations. (pydata#3513)
Deprecate allow_lazy (pydata#3435)
Recursive tokenization (pydata#3515)
format indexing.rst code with black (pydata#3511)
add missing pint integration tests (pydata#3508)
DOC: update bottleneck repo url (pydata#3507)
add drop_sel, drop_vars, map to api.rst (pydata#3506)
remove syntax warning (pydata#3505)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.reduce() on a DataArray with Dask distributed immediately executes the preceding portions of the computational graph

4 participants

@dcherian@shoyer@max-sixty@mathause