Trigger upstream CI on cron schedule (by default) - #4729

Merged

andersy005 merged 40 commits into

pydata:masterfrom

andersy005:ci/trigger-upstream-ci-on-cron-schedule-only

Jan 6, 2021

andersy005 commented Dec 23, 2020•
edited
Loading

Member

As discussed in today's dev meeting, this PR modifies the push and pull_request event triggers by making sure the upstream dev CI is triggered by cron schedule by default.

Passes isort . && black . && mypy . && flake8
User visible changes (including notable bug fixes) are documented in whats-new.rst
New functions/methods are listed in api.rst

Remove push and pull request event triggers

ccb315a

andersy005 added the CI label

keewis commented Dec 23, 2020•
edited
Loading

Collaborator

I think there were a few tricks we used to make sure certain steps are only run for the scheduled CI. Should we remove them now, or is it better to wait with that until we decide whether or not to move ~~all~~ most CI to Github Actions?

Remove github.event_name conditionals

5f2a1ea

andersy005 commented Dec 23, 2020

MemberAuthor

I think there were a few tricks we used to make sure certain steps are only run for the scheduled CI. Should we remove them now,

I just removed them (without the other event types, we don't need them anymore). I am going to submit another PR with the migration of the other CI to GitHub actions.

Enable running upstream-dev CI with special commit message

bd90d69

andersy005 commented

View reviewed changes

.github/workflows/upstream-dev-ci.yaml Outdated

andersy005 changed the title ~~Trigger upstream CI on cron schedule only~~Trigger upstream CI on cron schedule only (by default)

andersy005 changed the title ~~Trigger upstream CI on cron schedule only (by default)~~Trigger upstream CI on cron schedule (by default)

andersy005 added 2 commits

December 24, 2020 18:08

Add skip-ci message check per@dcherianrequest

69ad82c

Merge branch 'master' of github.com:pydata/xarray into ci/trigger-ups…

b426b55

…tream-ci-on-cron-schedule-only

keewis reviewed

View reviewed changes

.github/workflows/upstream-dev-ci.yaml

.github/workflows/upstream-dev-ci.yaml

.github/workflows/upstream-dev-ci.yaml Outdated

keewis reviewed

View reviewed changes

.github/workflows/upstream-dev-ci.yaml Outdated

andersy005 added 5 commits

December 29, 2020 16:23

Merge branch 'ci/trigger-upstream-ci-on-cron-schedule-only' of github…

5c86560

….com:andersy005/xarray; branch 'master' of github.com:pydata/xarray into ci/trigger-upstream-ci-on-cron-schedule-only

Put github.event_name == 'schedule' back in

abf2288

Fix if condition. Thanks@keewis

b21597a

Fix spacing

ddac8b2

Merge branch 'master' of github.com:pydata/xarray into ci/trigger-ups…

f791f36

…tream-ci-on-cron-schedule-only

keewis reviewed

View reviewed changes

keewis left a comment •
edited
Loading

Collaborator

with my suggestion this works, but it will leave a extra job.

For reference, we somehow have to extract the subject line to make sure the extra build was requested for this commit (squash merges concatenate the commit messages of all commits of a PR into a single commit).

Once github allows accessing only the subject (or adds string manipulation to the expression syntax) we might be able to get rid of this.

.github/workflows/upstream-dev-ci.yaml

.github/workflows/upstream-dev-ci.yaml

.github/workflows/upstream-dev-ci.yaml Outdated

keewis mentioned this pull request

Migrate CI from azure pipelines to GitHub Actions #4730

Merged

6 tasks

andersy005and others added 10 commits

January 3, 2021 17:40

Add detect-ci-tirgger job per@keewisfeedback

0d99d80

Co-authored-by: keewis <keewis@users.noreply.github.com>

Checkout git repo

cd31a14

Merge branch 'master' of github.com:pydata/xarray into ci/trigger-ups…

d4d3019

…tream-ci-on-cron-schedule-only

empty commit to trigger the CI [test-upstream]

2a8bc85

dedent the outputs section

a1593f0

add always to make sure the scheduled CI can run if check is skipped

6481823

empty commit to trigger the CI [test-upstream]

96ab916

add a step to print the detected status

fe67ddd

empty commit to trigger the CI [test-upstream]

9020137

also print the commit message

bdfccd8

andersy005 added 3 commits

January 3, 2021 19:55

Try head_ref

ec023b8

Fix typo

8802aac

[test-upstream] Increase n by 1

9cfe1e8

andersy005 commented

View reviewed changes

.github/workflows/upstream-dev-ci.yaml Outdated

keewis added 4 commits

January 4, 2021 15:33

add more steps to print information

687f419

use HEAD or HEAD^2 to get the correct commit message

50f9cc0

fix the bash conditional

04a9478

empty commit [test-upstream]

4baacc3

andersy005 commented

View reviewed changes

.github/workflows/upstream-dev-ci.yaml Outdated

Merge branch 'master' of github.com:pydata/xarray into ci/trigger-ups…

2cdccab

…tream-ci-on-cron-schedule-only

keewis commented Jan 4, 2021

Collaborator

now that it works, we should probably document [test-upstream] somewhere. I think this would fit in the PR template (as a comment?) or the contributing guide.

keewis mentioned this pull request

action to detect a keyword in the commit summary line #4764

Merged

andersy005 added 2 commits

January 5, 2021 13:52

Merge branch 'master' of github.com:pydata/xarray into ci/trigger-ups…

4e74c13

…tream-ci-on-cron-schedule-only

[test-upstream] Use actions/detect-ci-trigger

368dfb5

keewis reviewed

View reviewed changes

.github/workflows/upstream-dev-ci.yaml Outdated

[test-upstream] Document how to trigger upstream CI

69e4218

andersy005 commented

View reviewed changes

.github/PULL_REQUEST_TEMPLATE.md Outdated

Remove the part about the body of the git commit

4596f47

keewis reviewed

View reviewed changes

.github/PULL_REQUEST_TEMPLATE.md Outdated

Update text about git commit message

dbfecd6

Co-authored-by: keewis <keewis@users.noreply.github.com>

keewis approved these changes

View reviewed changes

keewis reviewed

View reviewed changes

.github/PULL_REQUEST_TEMPLATE.md Outdated

rewording

14c3c96

keewis commented Jan 6, 2021

Collaborator

@andersy005, I think this is ready. Feel free to merge.

Merge branch 'master' of github.com:pydata/xarray into ci/trigger-ups…

8f3646e

…tream-ci-on-cron-schedule-only

andersy005 commented Jan 6, 2021

MemberAuthor

Thank you for input and feedback @keewis and @dcherian

andersy005 merged commit bc49e27 into pydata:master

andersy005 deleted the ci/trigger-upstream-ci-on-cron-schedule-only branch

January 6, 2021 22:17

keewis mentioned this pull request

scheduled upstream-dev CI is skipped #4801

Closed

dcherian added a commit to TomNicholas/xarray that referenced this pull request

Merge remote-tracking branch 'upstream/master' into integrate_dim_arg

b9c1e6f

* upstream/master: (342 commits)
fix decode for scale/ offset list (pydata#4802)
Expand user dir paths (~) in open_mfdataset and to_zarr. (pydata#4795)
add a version info step to the upstream-dev CI (pydata#4815)
fix the ci trigger action (pydata#4805)
scatter plot by order of the first appearance of hue (pydata#4723)
don't skip the scheduled CI (pydata#4806)
coords: retain str dtype (pydata#4759)
Fix interval labels with units (pydata#4794)
Always force dask arrays to float in missing.interp_func (pydata#4771)
Print number of variables in repr (pydata#4762)
install conda as a library in the minimum dependency check CI (pydata#4792)
Migrate CI from azure pipelines to GitHub Actions (pydata#4730)
use conda.api instead of parallel calls to the conda binary (pydata#4775)
Speed up missing._get_interpolator (pydata#4776)
Remove special case in guess_engines (pydata#4777)
improve typing of OrderedSet (pydata#4774)
CI: ignore some warnings (pydata#4773)
DOC: update hyperlink for xskillscore (pydata#4778)
drop support for python 3.6 (pydata#4720)
Trigger upstream CI on cron schedule (by default) (pydata#4729)
...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment