Skip to content

Always force dask arrays to float in missing.interp_func - #4771

Merged
mathause merged 5 commits into
pydata:masterfrom
Illviljan:Illviljan-interp_correct_dtype
Jan 12, 2021
Merged

Always force dask arrays to float in missing.interp_func#4771
mathause merged 5 commits into
pydata:masterfrom
Illviljan:Illviljan-interp_correct_dtype

Conversation

@Illviljan

@IllviljanIllviljan commented Jan 6, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

scipy.interpolate.interp1d always forces float so make sure that da.blockwise understands that as well.

@pep8speaks

pep8speaks commented Jan 6, 2021•
edited
Loading

Copy link
Copy Markdown

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-06 12:04:04 UTC

dcherian
dcherian reviewed Jan 8, 2021
View reviewed changes
Comment threadxarray/core/missing.py
@mathause
mathause merged commit 9bb0302 into pydata:masterJan 12, 2021
@mathause

mathause commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator

thanks @Illviljan! Do I understand correctly - this does not resolve #4770 and we should leave it open?

@Illviljan

Illviljan commented Jan 12, 2021

Copy link
Copy Markdown
ContributorAuthor

@mathause In the ideal world I think we should get back the same dtype as it was before interpolation.
If we handle that with the same performance then it can be closed. Might be tough to close it though because when I've simply tested using .astype() it unfortunately slows down too much.

Maybe rewording the title a bit is in order or should we make a new one?

@mathausemathause mentioned this pull request Jan 12, 2021
Open
dcherian added a commit to TomNicholas/xarray that referenced this pull request Jan 18, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into integrate_dim_arg
b9c1e6f
* upstream/master: (342 commits)
fix decode for scale/ offset list (pydata#4802)
Expand user dir paths (~) in open_mfdataset and to_zarr. (pydata#4795)
add a version info step to the upstream-dev CI (pydata#4815)
fix the ci trigger action (pydata#4805)
scatter plot by order of the first appearance of hue (pydata#4723)
don't skip the scheduled CI (pydata#4806)
coords: retain str dtype (pydata#4759)
Fix interval labels with units (pydata#4794)
Always force dask arrays to float in missing.interp_func (pydata#4771)
Print number of variables in repr (pydata#4762)
install conda as a library in the minimum dependency check CI (pydata#4792)
Migrate CI from azure pipelines to GitHub Actions (pydata#4730)
use conda.api instead of parallel calls to the conda binary (pydata#4775)
Speed up missing._get_interpolator (pydata#4776)
Remove special case in guess_engines (pydata#4777)
improve typing of OrderedSet (pydata#4774)
CI: ignore some warnings (pydata#4773)
DOC: update hyperlink for xskillscore (pydata#4778)
drop support for python 3.6 (pydata#4720)
Trigger upstream CI on cron schedule (by default) (pydata#4729)
...
@Illviljan
Illviljan deleted the Illviljan-interp_correct_dtype branch May 18, 2021 18:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcheriandcheriandcherian approved these changes
@andersy005andersy005andersy005 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Illviljan@pep8speaks@mathause@dcherian@andersy005