REF: Make mypy manual stage with pre-commit

[snowman2]

With this setup, the mypy hook is only added to the run if you specify it:

pre-commit run --all-files --hook-stage manual

cc: @dcherian

https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

[max-sixty]

Thanks @snowman2 .

This is excellent! I didn't know we could pass --all like that.

I'm a 👍. Can we update the PR template to include that flag?

[dcherian]

I like this!

[snowman2]

I didn't know we could pass --all like that.

I think it is equivalent to --all-files

[Illviljan]

Is mypy being run in the CI now?

[snowman2]

Is mypy being run in the CI now?

Yes, it runs on the CI

[max-sixty]

Ah — one thing to check — I'm not sure it's running in https://results.pre-commit.ci/run/github/13221727/1637775215.Vi4gz7adRWeUAsEu1oJeZA — can we make it? We were hoping to replace the existing CI job with this.

[snowman2]

can we make it?

I am not seeing an option to do that: https://pre-commit.ci/

[max-sixty]

OK, I'd vote to merge this, leave the existing CI job, and then remove it when pre-commit.ci allows running manual stages. One of the main benefits of pre-commit.ci is that it adds changes to the branch, which doesn't help for mypy anyway.

[max-sixty]

I'm sorry this dropped. Could we resolve conflicts and then merge?

[snowman2]

No worries. I will try to address the conflicts when I get a free moment. Though, I wouldn't complain if someone else with a sooner free moment finished this one off before I do :-).

[max-sixty]

Thanks a lot @snowman2 !