Skip to content

Add pyupgrade onto pre-commit - #6152

Merged
max-sixty merged 11 commits into
pydata:mainfrom
max-sixty:pyupgrade
Jan 19, 2022
Merged

Add pyupgrade onto pre-commit#6152
max-sixty merged 11 commits into
pydata:mainfrom
max-sixty:pyupgrade

Conversation

@max-sixty

Copy link
Copy Markdown
Collaborator
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

This auto-fixes problems, so the bar to add it on is low...

Comment threadxarray/core/dataset.py
Comment threaddoc/whats-new.rst Outdated

@IllviljanIllviljan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I haven't tried this locally but does it slow down the local runs noticeably? Might be annoying for those who do local pre-commits in that case. But it fits great for the CI and since the bot will autocorrect now I think it outweighs the cons.
One can always turn off the local pre-commit and rely on the CI instead if it becomes to annoying.

@keewis

Copy link
Copy Markdown
Collaborator

Might be annoying for those who do local pre-commits in that case.

We might need to merge the part of #6024 that deactivates mypy in default pre-commit runs and add a new CI job instead...

@max-sixty
max-sixty merged commit 176c6eb into pydata:mainJan 19, 2022
@max-sixty
max-sixty deleted the pyupgrade branch January 19, 2022 20:39
@max-sixty

Copy link
Copy Markdown
CollaboratorAuthor

does it slow down the local runs noticeably?

These ones are fast! mypy is the laggard...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@max-sixty@keewis@Illviljan