Uh oh!
There was an error while loading. Please reload this page.
Improve perf of xr.corr - #6638
Closed
max-sixty wants to merge 1 commit into
Closed
Conversation
max-sixty
commented
May 26, 2022
CollaboratorAuthor
Because we want an all-NaN slice to return NaN for If there were a numba implementation of corr or cov, that would be far more performant than these, which are doing multiple passes & copies of each array, as well as blowing out any single-dimensions with the I'll close this. If anyone has alternative ideas, please feel free to raise. |
max-sixty added a commit
to max-sixty/xarray
that referenced
this pull request
May 27, 2022
max-sixty added a commit
that referenced
this pull request
May 27, 2022
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Jun 12, 2022
* main: (95 commits) Use `zarr` to validate attrs when writing to zarr (pydata#6636) Add pre-commit hook to check CITATION.cff (pydata#6658) Fix kwargs used for extrapolation in docs (pydata#6639) Fix notebooks' HTML links (pydata#6655) Doc index update (pydata#6530) CFTime support for polyval (pydata#6624) Support dask arrays in datetime_to_numeric (pydata#6556) [pre-commit.ci] pre-commit autoupdate (pydata#6654) 0-padded month. (pydata#6653) [test-upstream] import `cleanup` fixture from `distributed` (pydata#6650) Allow all interp methods in typing (pydata#6647) Typing support for custom backends (pydata#6651) Improved DataArray typing (pydata#6637) Adjust code comments & types from pydata#6638 (pydata#6642) Typing of `str` and `dt` accessors (pydata#6641) Feature/to dict encoding (pydata#6635) fix {full,zeros,ones}_like overloads (pydata#6630) Mypy badge (pydata#6626) concatenate docs style (pydata#6621) Typing for open_dataset/array/mfdataset and to_netcdf/zarr (pydata#6612) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should improve the performance of
xr.corr&xr.cov, but I'm not sure about dask arrays. I haven't been able to do tests on them, but I can do that soon unless anyone has an a priori view.