Skip to content

Allow all interp methods in typing - #6647

Merged
Illviljan merged 17 commits into
pydata:mainfrom
Illviljan:typing_interp_methods
May 29, 2022
Merged

Allow all interp methods in typing#6647
Illviljan merged 17 commits into
pydata:mainfrom
Illviljan:typing_interp_methods

Conversation

@Illviljan

@IllviljanIllviljan commented May 27, 2022

Copy link
Copy Markdown
Contributor

Follow up from #6637.

@Illviljan

Copy link
Copy Markdown
ContributorAuthor

Was just a typo @headtr1ck right? I'm not missing something?

@IllviljanIllviljan changed the title Allow all interp options in typingAllow all interp methods in typingMay 27, 2022
@headtr1ck

Copy link
Copy Markdown
Collaborator

Was just a typo @headtr1ck right? I'm not missing something?

I was not sure about that when I started the typing additions. I took the ones listed in the docstring.
But if mypy does not complain and the underlying functions support that it should be fine.
Thats the nice thing about typing ;)

@headtr1ck

Copy link
Copy Markdown
Collaborator

I think InterpOptions is then not used anymore and could be removed (or add a _ prefix).

@headtr1ck

Copy link
Copy Markdown
Collaborator

@Illviljan you should enable pre-commit hooks :)

@Illviljan

Copy link
Copy Markdown
ContributorAuthor

pre-commit hooks doesn't play nicely with Github Desktop, so that's why I don't use it.

@IllviljanIllviljan added the run-benchmark Run the ASV benchmark workflow label May 28, 2022
@Illviljan
Illviljan merged commit 3e099e4 into pydata:mainMay 29, 2022
@Illviljan
Illviljan deleted the typing_interp_methods branch May 29, 2022 11:33
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 12, 2022
* main: (95 commits)
Use `zarr` to validate attrs when writing to zarr (pydata#6636)
Add pre-commit hook to check CITATION.cff (pydata#6658)
Fix kwargs used for extrapolation in docs (pydata#6639)
Fix notebooks' HTML links (pydata#6655)
Doc index update (pydata#6530)
CFTime support for polyval (pydata#6624)
Support dask arrays in datetime_to_numeric (pydata#6556)
[pre-commit.ci] pre-commit autoupdate (pydata#6654)
0-padded month. (pydata#6653)
[test-upstream] import `cleanup` fixture from `distributed` (pydata#6650)
Allow all interp methods in typing (pydata#6647)
Typing support for custom backends (pydata#6651)
Improved DataArray typing (pydata#6637)
Adjust code comments & types from pydata#6638 (pydata#6642)
Typing of `str` and `dt` accessors (pydata#6641)
Feature/to dict encoding (pydata#6635)
fix {full,zeros,ones}_like overloads (pydata#6630)
Mypy badge (pydata#6626)
concatenate docs style (pydata#6621)
Typing for open_dataset/array/mfdataset and to_netcdf/zarr (pydata#6612)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmarkRun the ASV benchmark workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Illviljan@headtr1ck