Skip to content

Fix polyval overloads - #7315

Merged
Illviljan merged 2 commits into
pydata:mainfrom
headtr1ck:polyval_typing
Nov 26, 2022
Merged

Fix polyval overloads#7315
Illviljan merged 2 commits into
pydata:mainfrom
headtr1ck:polyval_typing

Conversation

@headtr1ck

@headtr1ckheadtr1ck commented Nov 23, 2022

Copy link
Copy Markdown
Collaborator

Turns out the default value of arguments is important for overloads, haha.

@Illviljan
Illviljan merged commit 4e9535a into pydata:mainNov 26, 2022
@Illviljan

Copy link
Copy Markdown
Contributor

Thank you @headtr1ck ! :)

dcherian added a commit to dcherian/xarray that referenced this pull request Dec 2, 2022
* upstream/main: (39 commits)
Support the new compression argument in netCDF4 > 1.6.0 (pydata#6981)
Remove setuptools-scm-git-archive, require setuptools-scm>=7 (pydata#7253)
Fix mypy failures (pydata#7343)
Docs: add example of writing and reading groups to netcdf (pydata#7338)
Reset file pointer to 0 when reading file stream (pydata#7304)
Enable mypy warn unused ignores (pydata#7335)
Optimize some copying (pydata#7209)
Add parse_dims func (pydata#7051)
Fix coordinate attr handling in `xr.where(..., keep_attrs=True)` (pydata#7229)
Remove code used to support h5py<2.10.0 (pydata#7334)
[pre-commit.ci] pre-commit autoupdate (pydata#7330)
Fix PR number in what’s new (pydata#7331)
Enable `origin` and `offset` arguments in `resample` (pydata#7284)
fix doctests: supress urllib3 warning (pydata#7326)
fix flake8 config (pydata#7321)
implement Zarr v3 spec support (pydata#6475)
Fix polyval overloads (pydata#7315)
deprecate pynio backend (pydata#7301)
mypy - Remove some ignored packages and modules (pydata#7319)
Switch to T_DataArray in .coords (pydata#7285)
...
@headtr1ck
headtr1ck deleted the polyval_typing branch December 8, 2022 20:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to mergeFinal call for commentstopic-typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

polyval doesn't bind the output type

2 participants

@headtr1ck@Illviljan